[Bug 14966] New: Table header broken at detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Bug ID: 14966 Summary: Table header broken at detail.tt Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: rkopaczka@afm.edu.pl Reporter: rkopaczka@afm.edu.pl QA Contact: testopia@bugs.koha-community.org Created attachment 43168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43168&action=edit screenshot After Bug 14354, when user without permission to edit items, goes to page: /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx, table with item info is corrupted. See screenshot attached. Looks like additional '<td>', are unnecessary. A patch will follow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 --- Comment #1 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- Created attachment 43170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43170&action=edit Bug 14966:Table header broken at detail.tt For user without item edit permission, table at catalogue/detail.pl is corrupted. Test plan: 1) Log in as staff member, without edit item permission. 2) Go to biblio view, with items attached: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table does not display correctly. 3) Apply patch. 4) Repeat steps 1 and 2. Confirm patch works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43170|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43172&action=edit Bug 14966:Table header broken at detail.tt For user without item edit permission, table at catalogue/detail.pl is corrupted. Test plan: 1) Log in as staff member, without edit item permission. 2) Go to biblio view, with items attached: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table does not display correctly. 3) Apply patch. 4) Repeat steps 1 and 2. Confirm patch works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |liz@catalyst.net.nz --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This one fixes a regression on stable branches 3.20.x and 3.18.x and should be backported on the next release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43172|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43325&action=edit [PASSED QA] Bug 14966:Table header broken at detail.tt For user without item edit permission, table at catalogue/detail.pl is corrupted. Test plan: 1) Log in as staff member, without edit item permission. 2) Go to biblio view, with items attached: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table does not display correctly. 3) Apply patch. 4) Repeat steps 1 and 2. Confirm patch works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Rafal! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15256 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256 [Bug 15256] Items table on detail page can be broken -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- This was released in 3.18.12 - sorry I missed it when I was updating bugs. Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org