https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83972&action=edit Bug 22134: Add account expiration information to patron details This patch modifies the patron detail template in the staff client so that when a patron's registration is expired a message shows at the top of the page along with the same "Renew" and "Edit" links which appear on the checkout page. Links are also shown next the the expiration date in the body of the page. This patch also corrects the capitalization of the "Edit Details" link on circulation.tt. To test, apply the patch and locate a patron record which is expired. - On the patron detail page (members/moremember.pl) you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. - On the patron's checkout page the "Edit details" link in the expiration message should have correct capitalization. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83972|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 83998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83998&action=edit Bug 22134: Add account expiration information to patron details This patch modifies the patron detail template in the staff client so that when a patron's registration is expired a message shows at the top of the page along with the same "Renew" and "Edit" links which appear on the checkout page. Links are also shown next the the expiration date in the body of the page. This patch also corrects the capitalization of the "Edit Details" link on circulation.tt. To test, apply the patch and locate a patron record which is expired. - On the patron detail page (members/moremember.pl) you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. - On the patron's checkout page the "Edit details" link in the expiration message should have correct capitalization. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I think it shoudl be possible to use is_expired and is_going_to_expire from the template without having to pass template variable from the .pl file. I found some examples with is_child: [% IF patron.is_child %] Can you take a look please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 [Bug 19818] Add id into tag html from moremember.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84147&action=edit Bug 22134: (follow-up) Simplify check for expired patron This patch move the check for "is_expired" to the template and removes unnecessary code from the script. The interface should show no difference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84147|0 |1 is obsolete| | --- Comment #6 from Jack <jke0429@stacmail.net> --- Created attachment 84162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84162&action=edit Bug 22134: (follow-up) Simplify check for expired patron This patch move the check for "is_expired" to the template and removes unnecessary code from the script. The interface should show no difference. Signed-off-by: Jack Kelliher <jke0429@stacmail.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84191&action=edit Bug 22134: (follow-up) Simplify check for expired patron This patch move the check for "is_expired" to the template and removes unnecessary code from the script. The page now correctly handles messages for patrons who are about to expire, as defined in the NotifyBorrowerDeparture preference. To test, apply the patch and locate a patron record which is expired. - On the patron detail page (members/moremember.pl) you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. Select a patron who will expire within the period defined in NotifyBorrowerDeparture. - On the patron detail page you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83998|0 |1 is obsolete| | --- Comment #8 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84214&action=edit Bug 22134: Add account expiration information to patron details This patch modifies the patron detail template in the staff client so that when a patron's registration is expired a message shows at the top of the page along with the same "Renew" and "Edit" links which appear on the checkout page. Links are also shown next the the expiration date in the body of the page. This patch also corrects the capitalization of the "Edit Details" link on circulation.tt. To test, apply the patch and locate a patron record which is expired. - On the patron detail page (members/moremember.pl) you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. - On the patron's checkout page the "Edit details" link in the expiration message should have correct capitalization. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84238&action=edit k -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84215|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84241&action=edit Bug 22134: (follow-up) Simplify check for expired patron This patch move the check for "is_expired" to the template and removes unnecessary code from the script. The page now correctly handles messages for patrons who are about to expire, as defined in the NotifyBorrowerDeparture preference. To test, apply the patch and locate a patron record which is expired. - On the patron detail page (members/moremember.pl) you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. Select a patron who will expire within the period defined in NotifyBorrowerDeparture. - On the patron detail page you should see a message at the top of the page. - In the body of the page, next to the expiration date information, you should see similar message and links. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25299 -- You are receiving this mail because: You are watching all bug changes.