[Bug 36143] New: Pop-up window sizes are not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 Bug ID: 36143 Summary: Pop-up window sizes are not consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: dcook@prosentient.com.au, fridolin.somers@biblibre.com, jonathan.druart+koha@gmail.com, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, oleonard@myacpl.org It seems we have width+height specifically defined for each window.popup across the code base. These are some of the variants I could find, but there may be others: width=1000,height=600 width=1000,height=375 width=1000,height=575 width=900,height=700 width=800,height=400 width=800,height=550 width=800,height=500 width=700,height=700 width=700,height=600 width=700,height=400 width=700,height=550 This is not great, these should be standardized and configured once, example (values to be discussed): large: 1000 x 600 medium: 800 x 500 small: 700 x 400 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe only large and small in enough. Looks like small popups use around 4/3 ratio. So small could be width=800,height=600 Large use a more 16/9 ratio. So large could be width=1024,height=576 Actual width=800 and width=700 goes to small. Actual width=900 may fit in small, must be validated. Actual width=1000 goes to large. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 [Bug 35134] cn_browser.pl pop-up size should be configurable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I'd love to see the approach in bug 35134 extended to here.. I think three sizes of popup make sense and having those three sizes user customisable using the approach in bug 35134 would be even better... I also like that instead of a hard coded default, the default introduced in 35134 is calculated from the window size to start. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org