[Bug 40306] New: Use GET in form of value_builder/unimarc_field_4XX.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Bug ID: 40306 Summary: Use GET in form of value_builder/unimarc_field_4XX.pl Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36577 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like Bug 36577 for MARC21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 183791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183791&action=edit Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl Test plan: 1) Use UNIMARC DB 2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t 3) Create a new biblio record 4) On 461$t click on 'Tag editor' icon 5) Perform a search 6) Click on choose 7) Field 461 is filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40307 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183791|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 183804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183804&action=edit Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl Test plan: 1) Use UNIMARC DB 2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t 3) Create a new biblio record 4) On 461$t click on 'Tag editor' icon 5) Perform a search 6) Click on choose 7) Field 461 is filled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes searching for release notes| |terms when using the | |unimarc_field_4XX.pl value | |builder. The 'Start search' | |button now works, instead | |of doing nothing. (UNIMARC | |instances.) (This is | |related to the CSRF changes | |added in Koha 24.05 to | |improve form security.) CC| |david@davidnind.com Depends on| |36192 --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Startup KTD with UNIMARTC: Edit your .env file and set KOHA_MARC_FLAVOUR=unimarc 2. For the default framework, the value builder unimarc_field_4XX.pl is already configured for 461$t. 3. Create a new bibliographic record. 4. For 461$t, click the 'Tag editor'. 5. Search for something, for example: a 6. Click 'Start search' - nothing happens. 7. Apply the patch. 8. Refresh the editor and repeat steps 4 and 5. 9. The 'Start search' button now works. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks like number.startfrom is wrong too ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Marcel de Rooy from comment #5)
Looks like number.startfrom is wrong too ?
Ah there are 2 vars startfrom : my $startfrom = $query->param('startfrom'); And : push @numbers, { number => $i, highlight => $highlight, searchdata => \@field_data, startfrom => ( $i - 1 ) }; In this case number.startfrom is correct. You can look at "marc21_linking_section.tt" that is nearly the same code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192275&action=edit Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl Test plan: 1) Use UNIMARC DB 2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t 3) Create a new biblio record 4) On 461$t click on 'Tag editor' icon 5) Perform a search 6) Click on choose 7) Field 461 is filled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192275|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 195316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195316&action=edit Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl Test plan: 1) Use UNIMARC DB 2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t 3) Create a new biblio record 4) On 461$t click on 'Tag editor' icon 5) Perform a search 6) Click on choose 7) Field 461 is filled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |synapse.ova@gmail.com --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- *** Bug 42095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40306 --- Comment #11 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org