[Bug 36907] New: OAI set mapping form field maxlength should match table column sizes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Bug ID: 36907 Summary: OAI set mapping form field maxlength should match table column sizes Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you enter text in the OAI set mapping form which contains more characters than the size of the oai_sets_mappings database columns and submit the form there is causes an error. "C4::OAI::Sets::ModOAISetMappings(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'marcfield' at row 1" We should add maxlength attributes to these fields to prevent that possibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166984&action=edit Bug 36907: Add maxlength to OAI set mapping form fields This patch adds a maxlength attribute to the field, subfield, and value fields in the OAI set mapping form. This helps prevent an error when the form data is too long for the database columns. Unrelated: The patch also adds quotes around two unquoted name attributes. To test, apply the patch and go to Administration -> OAI sets. - If necessary, create a new set. - Click Actions -> Define mappings. - Test that each form field is limited correctly: Field: 3 Subfield: 1 Value: 80 - Test that the form can be submitted successfully with the maximum number of characters in each field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166984|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167062&action=edit Bug 36907: Add maxlength to OAI set mapping form fields This patch adds a maxlength attribute to the field, subfield, and value fields in the OAI set mapping form. This helps prevent an error when the form data is too long for the database columns. Unrelated: The patch also adds quotes around two unquoted name attributes. To test, apply the patch and go to Administration -> OAI sets. - If necessary, create a new set. - Click Actions -> Define mappings. - Test that each form field is limited correctly: Field: 3 Subfield: 1 Value: 80 - Test that the form can be submitted successfully with the maximum number of characters in each field. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the OIA set release notes| |mappings form so that you | |can't enter more characters | |than the maximum length for | |the input fields (Field | |(3), Subfield (1), and | |Value (80)). Previously, | |you could enter more | |characters - however, when | |you saved the form it | |generated an error. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167062|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 170442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170442&action=edit Bug 36907: Add maxlength to OAI set mapping form fields This patch adds a maxlength attribute to the field, subfield, and value fields in the OAI set mapping form. This helps prevent an error when the form data is too long for the database columns. Unrelated: The patch also adds quotes around two unquoted name attributes. To test, apply the patch and go to Administration -> OAI sets. - If necessary, create a new set. - Click Actions -> Define mappings. - Test that each form field is limited correctly: Field: 3 Subfield: 1 Value: 80 - Test that the form can be submitted successfully with the maximum number of characters in each field. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36907 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org