[Bug 9806] New: Show more information on basketgroups lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Bug ID: 9806 Summary: Show more information on basketgroups lists Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. For libraries using basketgroup, it would be very usefull to see more information, all the more since librarians cannot see the content of a basketgroup without reopening it (this point could be fixed in an other bug...) To begin, I propose to add the following columns : - basketgroupnumber - billingplace - deliveryplace - number of baskets in each basketgroup and maybe later : - date of creation - date of closure - the list of baskets included in the basketgroup - number of orders - number received/non received orders M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16173&action=edit [PATCH] Bug 9806 : Add new columns to basket groups lists In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- zut! I will rebase it tomorrow. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- you need to apply BZ 9771 first. I suppose you cannot in a sandbox ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #3)
zut! I will rebase it tomorrow. M. Saby
There are several whitespace changes in your patch. You should split your patch into feature and cosmetic changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16173|0 |1 is obsolete| | --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16307&action=edit PATCH 1/2][Revised] Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16309&action=edit [PATCH 2/2] cosmetic patch (reindent part of basketgroup.tt) Only reindenting the end of basketgroup.tt M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Still to apply on the top of 9771. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16309|0 |1 is obsolete| | --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Comment on attachment 16309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16309 [PATCH 2/2] cosmetic patch (reindent part of basketgroup.tt) Cosmetic patch is useless M. saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9771 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16307|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16509&action=edit [SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice improvement! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #11 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Note : bz9771 has been pushed to master some minutes ago. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #12 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Why not using Koha::Template::Plugin::KohaBranchName to change branch code into branch description into template instead of into perl page ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I did not know it was possible ;-) If you think it is a better solution I will rewrite my patch. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #14 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I think it would be great. Have a look at Bug 9229 patch to see how to do it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- I agree with the Fridolyn's proposal. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #16 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I had forgotten this bug... Will take a look later and rewrite it. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #17 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 18228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18228&action=edit [PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com --- Comment #18 from Pierre Angot <tredok.pierre@gmail.com> --- Test on sandbox : Sandbox setup by tredok.pierre@gmail.com with database 2 and bug 9806 on Thu May 23 08:44:09 2013 Something went wrong ! Applying: Bug 9806 : Add new columns to basket groups lists Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Applying: Bug 9806 : QA Followup - use template plugin for branch names Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9806 : QA Followup - use template plugin for branch names When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9806 - Show more information on basketgroups lists [SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists Apply? [yn] [PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names Apply? [yn] Patch left in /tmp/PATCH-2-Bug-9806--QA-Followup---use-template-plugi-GS6lZO.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- The patches apply correctly on a local instance. Switch back to Needs SO. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #20 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thank you Jonathan. I could not check this morning, I am struggling with my VM... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 18331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18331&action=edit Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #23 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- So, it is working? Your sandbox was not rightly set-up ? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Ergonomic improvement for the basket group table. Simple patch, just add some columns on the table. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16509|0 |1 is obsolete| | Attachment #18331|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18333&action=edit Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Owen Leonard <oleonard@myacpl.org> This is a nice improvement! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18334&action=edit Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18335&action=edit Bug 9806: Remove single pixel on the basketgroup table Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- The last patch fixes a small issue with the Datatable sDom. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #29 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Jonathan, that's not my patch... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #29)
Jonathan, that's not my patch...
Hum... 2 first patchs is yours. Last one is mine. It is a QA followup. Do you disagree with it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #31 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- If it is a QA patch, that's ok! In fact I did not look... I just look the title, and it reminds me an other bug, so I thought it as an attachement error. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #32 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (it reminds me BZ 10287) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #33 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org