[Bug 35211] New: Make it possible to add new tab to record’s detail page catalogue/detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Bug ID: 35211 Summary: Make it possible to add new tab to record’s detail page catalogue/detail.pl Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: kati.sillgren@porvoo.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Make it possible to add new tab to record’s detail page/holdings table by using library groups. Library groups are made here: admin/library_groups.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #1 from Kati Sillgren <kati.sillgren@porvoo.fi> --- Tab is shown automatically according to the library where Koha-user is logged in, and library is included to the library group (search group). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Summary|Make it possible to add new |Make it possible to split |tab to record’s detail page |holdings tab using library |catalogue/detail.pl |groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #2 from Jessie Zairo <jzairo@bywatersolutions.com> --- +1 this would be helpful for large systems, consortiums, and library networks to breakdown multi-branch systems and see whats available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #3 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183075&action=edit Bug 35211: Add group_holdings tab to Holdings table Current status: ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183075|0 |1 is obsolete| | Attachment #183099|0 |1 is obsolete| | --- Comment #4 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183099&action=edit Bug 35211: Add group_holdings tab to Holdings table --- Comment #5 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183143&action=edit Bug 35211: Add group_holdings tab to Holdings table Add new system preference 'SeparateHoldingsByGroup' Adds new tab to Group Holdings to Holdings table. Separates holdings by library group. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183143|0 |1 is obsolete| | --- Comment #6 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183144&action=edit Bug 35211: Add group_holdings tab to Holdings table Add new system preference 'SeparateHoldingsByGroup' Adds new tab to Group Holdings to Holdings table. Separates holdings by library group. Test Plan: 1. Apply patch, restart_all 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Separate items display into two tabs and Separate holdings by library group. 4. Save preference changes 5. Koha Administration -> Library groups 6. Create a library group and add check the 'Use for staff search groups' box. 7. Add libraries to the new group including your logged in branch. 8. Do a catalog search. 9. Click on an item that libraries in your group own. 10. Notice a new tab called Group Holdings that contains only the libraries in your group 11. Return to Koha Administration -> System preferences SeparateHoldingsByGroup 12. Don't separate holdings by library group 13. Return to the item you search for and notice the tab has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I found a few problems here: 1. There is a problem with the atomicupdate: ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ''variable','value','options','explanation','type') VALUES ('Separ...' at line 1 at /kohadevbox/koha/C4/Installer.pm line 825 2. The "Group holdings" do not seem to include the logged in branch's holdings 3. If there are more than one groups everything gets grouped together under the single tab "Group holdings". In my opinion there should be a separate tab for every group that the logged in library is a part of. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183144|0 |1 is obsolete| | --- Comment #8 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183420&action=edit Bug 35211: Add group_holdings tab to Holdings table Add new system preference 'SeparateHoldingsByGroup' Adds new tab to Group Holdings to Holdings table. Separates holdings by library group. Test Plan: 1. Apply patch, restart_all 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Separate items display into two tabs and Separate holdings by library group. 4. Save preference changes 5. Koha Administration -> Library groups 6. Create a library group and add check the 'Use for staff search groups' box. 7. Add libraries to the new group including your logged in branch. 8. Do a catalog search. 9. Click on an item that libraries in your group own. 10. Notice a new tab called Group Holdings that contains only the libraries in your group 11. Return to Koha Administration -> System preferences SeparateHoldingsByGroup 12. Don't separate holdings by library group 13. Return to the item you search for and notice the tab has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #9 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183615&action=edit Bug 35211: Separate group holdings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183420|0 |1 is obsolete| | --- Comment #10 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183642&action=edit Bug 35211: Add group_holdings tab to Holdings table Add new system preference 'SeparateHoldingsByGroup' Adds new tab to Group Holdings to Holdings table. Separates holdings by library group. Test Plan: 1. Apply patch, restart_all 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Separate items display into two tabs and Separate holdings by library group. 4. Save preference changes 5. Koha Administration -> Library groups 6. Create a library group and add check the 'Use for staff search groups' box. 7. Add libraries to the new group including your logged in branch. 8. Do a catalog search. 9. Click on an item that libraries in your group own. 10. Notice a new tab called Group Holdings that contains only the libraries in your group 11. Return to Koha Administration -> System preferences SeparateHoldingsByGroup 12. Don't separate holdings by library group 13. Return to the item you search for and notice the tab has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183615|0 |1 is obsolete| | --- Comment #11 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183643&action=edit Bug 35211: Separate group holdings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #12 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183901&action=edit Bug 35211: Separate group holdings into individual tabs Added SeparateHoldingsByGroup system preference Adds new tabs to Holdings table if preference is enabled Separates by library groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183901|0 |1 is obsolete| | --- Comment #13 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183945&action=edit Bug 35211: Separate group holdings into individual tabs Added SeparateHoldingsByGroup system preference Adds new tabs to Holdings table if preference is enabled Separates by library groups Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This orders the holdings tabs as Local / Other / Group. I think Local / Group / Other would make more sense, organizationally. You've labeled the group holdings tab with "[Group title] - Group". This would be more consistent if the label were "[Group title] holdings". We should add the same functionality in the OPAC, which has a separate OpacSeparateHoldings syspref. That could be a separate bug, but might make sense to cover here if it's more of less a copy/paste. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #15 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183949&action=edit Bug 35211 HEAD: Reordered tabs in Holdings Table and fixed group tabnames -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #16 from Eric Garcia <cubingguy714@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #14)
We should add the same functionality in the OPAC, which has a separate OpacSeparateHoldings syspref. That could be a separate bug, but might make sense to cover here if it's more of less a copy/paste.
I think it should be a separate bug, might be more than a copy/paste -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183949|Bug 35211 HEAD: Reordered |Bug 35211: Reordered tabs description|tabs in Holdings Table and |in Holdings Table and fixed |fixed group tabnames |group tabnames -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183949|0 |1 is obsolete| | --- Comment #17 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183950&action=edit Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 183966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183966&action=edit empty group tab Thanks for those changes! Two more issues: 1 - Set SeparateHoldings="Don't separate" and SeparateHoldingsByGroup="Separate." See attached screenshot; the group holdings tab appears and shows an accurate count of record on the tab, but contains no items 2 - With both sysprefs set to Separate, items repeat between tabs -- the Group tab repeats the item held locally and the Other tab repeats the non-local group items. Items should show in only one tab -- local items in the local tab, non-local group items in the Group tab, non-local & non-group items in the Other tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make it possible to split |Make it possible to split |holdings tab using library |holdings tab using library |groups |groups in intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40342 [Bug 40342] Make it possible to split holdings tab using library groups in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #19 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183967&action=edit Bug 35211: Removed local items from group tabs and removed group items from other holdings tab Fixed the issues with tabs. I cannot replicate the issue in the attached screenshot. What steps did you take? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Eric Garcia from comment #19)
I cannot replicate the issue in the attached screenshot. What steps did you take?
- apply patch, updatedatabase, reset_all - log in at default branch, Centerville - go to bib 344 (E Street Shuffle, 3 items) - add 3 items to bib 344 with homebranch of Fairfield, Fairview, Franklin, respectively. holdingbranch remains Centerville - go to Admin, Groups. Create a group, check "Use for staff search groups", add Fairfield, Fairview, and Franklin to the group - in sysprefs, set SeparateHoldings="Don't Separate", SeparateHoldingsBranch="home library", SeparateHoldingsByGroup="Separate" - set your logged-in-branch to Fairfield - load bib 344 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #21 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 183968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183968&action=edit Bug 35211: Fixed count on logged in holdings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Eric Garcia from comment #21)
Created attachment 183968 [details] [review] Bug 35211: Fixed count on logged in holdings
I'm seeing some odd behavior now. Testing with the same setup described above (6 items on bib 344, group of F libraries). With: SeparateHoldings = Separate, SeparateHoldingsByGroup = Separate, SeparateHoldingsBranch = Home, logged in at Fairfield: I don't get a group holdings tab, just local and Other. The two non-local group items are not displayed at all With: SeparateHoldings = Separate, SeparateHoldingsByGroup = Separate, SeparateHoldingsBranch = Holding, logged in at Fairfield: No local tab, no group tab. There is not a tab selected at page load. The Other holdings tab shows a count of 4 but actually lists all 6 items. With apologies for being slow to think of this, but I don't think SeparateHoldingsByGroup can be coded to always go by homebranch; it should also follow SeparateHoldingsBranch. That further suggests these three sysprefs should get grouped together and rephrased a bit. Maybe: [Don't separate/Separate] items held by the user's logged-in library into the first tab of the items display. [Don't separate/Separate] items held by other libraries in a staff search group with the user's logged-in library into the next tab of the items display. The final tab will contain all other items. Use the items' [holding library/homelibrary] for determining these groupings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #23 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 184016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184016&action=edit Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Something is wrong here. SeparateHoldingsByGroup isn't working at all for me now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sspohn@oslri.net --- Comment #25 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 38652 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #26 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 185336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185336&action=edit Bug 35211: Fix tab building Fixed naming when building tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi Status|Needs Signoff |Patch doesn't apply --- Comment #27 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a sandbox and it's not working as I thought it would work. * I made a library group 1, 2 and 3. In Group 2 there were Fairview and Franklin. * I added items to the biblio so that there were items in Centerville, Fairfield, Fairview and Franklin. * I selected Fairview as my login library. * A new Group 2 holdings tab appeared but there were only item from Franklin. I was expecting it to contain items from Fairview AND Franklin. The Fairview's items were shown only in the Holdings tab. * I added Centerville to the Group 2 and it's items showed up in the Group 2 holdings tab. Still no Fairview items in the group tab. So I would say this does not work as expected. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #28 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 185515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185515&action=edit Bug 35211: Fixed group tab item building logic Changed to show logged in branch in group tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40668 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183945|0 |1 is obsolete| | --- Comment #29 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185525&action=edit Bug 35211: Separate group holdings into individual tabs Worked as expected Added SeparateHoldingsByGroup system preference Adds new tabs to Holdings table if preference is enabled Separates by library groups Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183950|0 |1 is obsolete| | --- Comment #30 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185526&action=edit Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183967|0 |1 is obsolete| | --- Comment #31 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185527&action=edit Bug 35211: Removed local items from group tabs and removed group items from other holdings tab Fixed the issues with tabs. I cannot replicate the issue in the attached screenshot. What steps did you take? Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183968|0 |1 is obsolete| | --- Comment #32 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185528&action=edit Bug 35211: Fixed count on logged in holdings Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184016|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185529&action=edit Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185336|0 |1 is obsolete| | --- Comment #34 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185530&action=edit Bug 35211: Fix tab building Fixed naming when building tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185515|0 |1 is obsolete| | --- Comment #35 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185531&action=edit Bug 35211: Fixed group tab item building logic Changed to show logged in branch in group tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bywater@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185525|0 |1 is obsolete| | --- Comment #36 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188553&action=edit Bug 35211: Separate group holdings into individual tabs Added SeparateHoldingsByGroup system preference Adds new tabs to Holdings table if preference is enabled Separates by library groups Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185526|0 |1 is obsolete| | --- Comment #37 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188554&action=edit Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185527|0 |1 is obsolete| | --- Comment #38 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188555&action=edit Bug 35211: Removed local items from group tabs and removed group items from other holdings tab Fixed the issues with tabs. I cannot replicate the issue in the attached screenshot. What steps did you take? Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185528|0 |1 is obsolete| | --- Comment #39 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188556&action=edit Bug 35211: Fixed count on logged in holdings Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185529|0 |1 is obsolete| | --- Comment #40 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188557&action=edit Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185530|0 |1 is obsolete| | --- Comment #41 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188558&action=edit Bug 35211: Fix tab building Fixed naming when building tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185531|0 |1 is obsolete| | --- Comment #42 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188559&action=edit Bug 35211: Fixed group tab item building logic Changed to show logged in branch in group tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #43 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189379&action=edit Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array The other holds tab was showing even when no other holdings existed, so I fixed it to only show when there were other holdings. I also fixed tab creation so the template toolkit to create a tab for each group if there's muliple groups is concated instead of inside the array. I don't love that the libraries have to be search groups in the staff interface for it to work, but I'll make sure to note in the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |system preference | |`SeparateHoldingsByGroup` | |to separate by group | |instead of branch Status|Passed QA |Failed QA --- Comment #44 from Lisette Scheer <lisette@bywatersolutions.com> --- Hmm, I broke something when fixing the math for other holdings. I'll fix it early next week before the feature freeze. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188553|0 |1 is obsolete| | --- Comment #45 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189442&action=edit Bug 35211: Separate group holdings into individual tabs Added SeparateHoldingsByGroup system preference Adds new tabs to Holdings table if preference is enabled Separates by library groups Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189442|0 |1 is obsolete| | --- Comment #46 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189443&action=edit Bug 35211: Separate group holdings into individual tabs Added SeparateHoldingsByGroup system preference Adds new tabs to Holdings table if preference is enabled Separates by library groups Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188554|0 |1 is obsolete| | --- Comment #47 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189444&action=edit Bug 35211: Reordered tabs in Holdings Table and fixed group tabnames Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188555|0 |1 is obsolete| | --- Comment #48 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189445&action=edit Bug 35211: Removed local items from group tabs and removed group items from other holdings tab Fixed the issues with tabs. I cannot replicate the issue in the attached screenshot. What steps did you take? Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188556|0 |1 is obsolete| | --- Comment #49 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189446&action=edit Bug 35211: Fixed count on logged in holdings Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188557|0 |1 is obsolete| | --- Comment #50 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189447&action=edit Bug 35211: Set SeparateHoldingsByGroup to separate based on SeparateHoldingsBranch syspref Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188558|0 |1 is obsolete| | --- Comment #51 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189448&action=edit Bug 35211: Fix tab building Fixed naming when building tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188559|0 |1 is obsolete| | --- Comment #52 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189449&action=edit Bug 35211: Fixed group tab item building logic Changed to show logged in branch in group tabs Test Plan: 1. Apply patch, restart_all, updatedatabase 2. Koha Administration -> System preferences -> SeparateHoldingsByGroup 3. Change to "Separate holdings by library group in subsequent tabs..." and Save 4. Koha Administration -> Library Groups 5. Create multiple library groups and check the 'Use for staff search groups' box. 6. Add your logged in library to each group and other libraries to each group. 7. Do catalog searches where the location of the item is a library in a library group 8. Notice tabs in the Holdings table for each library group if it contains a library that has the item Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189379|0 |1 is obsolete| | --- Comment #53 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189450&action=edit Bug 35211: (QA follow-up) fix display of other results tab and move template toolkit logic outside of script array -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #54 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 189451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189451&action=edit Bug 35211: (QA follow-up) Fix counting This patch updates detail.pl and detail.tt to correctly count the number of items for each tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 ayoung <ayoung@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoung@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #55 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This will wait until 26.05. In the meantime it would be good to have some more robust release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate |release-notes-needed --- Comment #57 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- There are release notes but they are inadequate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a new |This enhancement adds a new release notes|system preference |system preference |`SeparateHoldingsByGroup` |`SeparateHoldingsByGroup.` |to separate by group |When this preference is |instead of branch |enabled and the logged-in | |library is part of a | |library group marked `Use | |for staff search groups,` | |the holdings table will | |include a tab listing all | |items with a homebranch | |within that group. When | |`SeparateHoldings` is also | |enabled, the `Other | |holdings` tab will only | |include items not owned by | |either the logged-in | |library or a library | |sharing a group with the | |logged-in library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #58 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191225&action=edit Bug 35211: (follow-up) Improve how branchcodes are handled -This patch is an attempt to improve how we retrive branchcodes. Too much of this logic is unnesseary done in the template. -This also removed the unneeded "use Koha::Library::Group;" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #59 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191226&action=edit Bug 35211: Move other_holdings_count outside of loop so it is only calculated once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191225|0 |1 is obsolete| | --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191230&action=edit Bug 35211: (follow-up) Improve how branchcodes are handled -This patch is an attempt to improve how we retrive branchcodes. Too much of this logic is unnesseary done in the template. -This also removed the unneeded "use Koha::Library::Group;" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191226|0 |1 is obsolete| | --- Comment #61 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191231&action=edit Bug 35211: Move other_holdings_count outside of loop so it is only calculated once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41624 [Bug 41624] Improvements to Bug 35211 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.zermatten@openfifth.c | |o.uk --- Comment #62 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Not backporting to 25.11.x (stable) as it's an enhancement / new feature. Happy to reconsider if needed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35211 --- Comment #63 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Chloé Zermatten from comment #62)
Not backporting to 25.11.x (stable) as it's an enhancement / new feature. Happy to reconsider if needed!
Do not backport, this entire patchset is now reverted from main. See Bug 41624 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org