[Bug 10398] New: We should have XML validity tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Bug ID: 10398 Summary: We should have XML validity tests Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18630&action=edit Bug 10398 - Provide xml_valid.t for checking XML validity This patch adds a script that checks every XML file in Koha's source tree using xmllint. To test: - Run find . -name '*.xml' - Apply the patch, and run prove -v xt/xml_valid.t - Verify every xml file was tested. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Interesting, but I think you are only checking well formed xml. For valid xml I think the command needs to be my @command = qw(xmllint --valid --noout); But in the case of 006/008 value builders you need to specify and external XSD, like (cd-ing to the apropriate folder) xmllint --schema marc21_field_CF.xsd --noout marc21_field_006.xml Anyway, well formed is good enough :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This bug is a duplicate of 5393, which I missed due to a bad search and the test itself being in t/ instead of xt/ as I expected. *** This bug has been marked as a duplicate of bug 5393 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org