[Bug 41190] New: "Default checkout, hold and return policy" needs a space in title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Bug ID: 41190 Summary: "Default checkout, hold and return policy" needs a space in title Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The title in this section appears like this: Default checkout, hold and return policyfor Calispel Valley Branch Library There needs to be a space after policy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 190257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190257&action=edit Bug 41190: Add space in "Default checkout, hold and return policy" title This patch adds a space in the title "Default checkout, hold and return policy" in the circulation rules page. To test: 1. Go to Administration > Circulation and fine rules 2. Select a library (e.g. Centerville) 3. Scroll down to the second table --> Note the title of the section is "Default checkout, hold and return policyfor Centerville" with a space missing between "policy" and "for" 4. Apply the patch 5. Refresh the page --> The title should now look normal with all the spaces! "Default checkout, hold and return policy for Centerville" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I just noticed this and thought it was a mistake in the translation! Easy fix and easy to test. Hopefully, it will go in fast :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190257|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190258&action=edit Bug 41190: Add space in "Default checkout, hold and return policy" title This patch adds a space in the title "Default checkout, hold and return policy" in the circulation rules page. To test: 1. Go to Administration > Circulation and fine rules 2. Select a library (e.g. Centerville) 3. Scroll down to the second table --> Note the title of the section is "Default checkout, hold and return policyfor Centerville" with a space missing between "policy" and "for" 4. Apply the patch 5. Refresh the page --> The title should now look normal with all the spaces! "Default checkout, hold and return policy for Centerville" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Had an off git error when trying to apply the patch: git bz apply 41190 Bug 41190 - "Default checkout, hold and return policy" needs a space in title 190257 - Bug 41190: Add space in "Default checkout, hold and return policy" title Apply? [(y)es, (n)o, (i)nteractive] y Patch is empty. Ended up editing the file to make the change and then amending the commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #5 from David Nind <david@davidnind.com> --- ... 'off' should be 'odd'! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Tried signing off and got this via sandbox: Saved working directory and index state WIP on main: 3f2987eb19 Koha 25.11.00 is here! /bin/sh: 1: Brannon: not found fatal: It looks like 'git am' is in progress. Cannot rebase. On branch main Your branch is up to date with 'origin/main'. You are in the middle of an am session. (fix conflicts and then run "git am --continue") (use "git am --skip" to skip this patch) (use "git am --abort" to restore the original branch) Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) [31mmodified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt[m no changes added to commit (use "git add" and/or "git commit -a") Dropped refs/stash@{0} (8322473a76a0270c3b5e3889486191acf550476e) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #7 from David Nind <david@davidnind.com> --- The patch should apply cleanly now. If you can add your sign-off, then I can do the QA (it's a string patch, and within my capabilities to QA!). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #4)
Had an off git error when trying to apply the patch:
git bz apply 41190
Bug 41190 - "Default checkout, hold and return policy" needs a space in title
190257 - Bug 41190: Add space in "Default checkout, hold and return policy" title
Apply? [(y)es, (n)o, (i)nteractive] y Patch is empty.
Ended up editing the file to make the change and then amending the commit.
Whoops, sorry! I guess I was feeling too confident even if it was friday afternoon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190258|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 190831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190831&action=edit Bug 41190: Add space in "Default checkout, hold and return policy" title This patch adds a space in the title "Default checkout, hold and return policy" in the circulation rules page. To test: 1. Go to Administration > Circulation and fine rules 2. Select a library (e.g. Centerville) 3. Scroll down to the second table --> Note the title of the section is "Default checkout, hold and return policyfor Centerville" with a space missing between "policy" and "for" 4. Apply the patch 5. Refresh the page --> The title should now look normal with all the spaces! "Default checkout, hold and return policy for Centerville" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just noticed, sorry for stealing QA, David :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Paul Derscheid from comment #10)
Just noticed, sorry for stealing QA, David :)
No worries, thanks for QAing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds a space to the release notes| |circulation rules section | |heading for "Default | |checkout, hold and return | |policy" when a library is | |selected. | | | |Example: | |- With a library selected, | |such as Centerville, the | |rule heading is missing a | |space "Default checkout, | |hold and return policyfor | |Centerville" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 --- Comment #13 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41190 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |CLOSED CC| |catrina@bywatersolutions.co | |m --- Comment #15 from Catrina Berka <catrina@bywatersolutions.com> --- No documentation needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org