[Bug 7485] New: Cannot edit barcode on Fast Add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Bug #: 7485 Summary: Cannot edit barcode on Fast Add Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: wizzyrea@gmail.com QAContact: koha.sekjal@gmail.com When new records use the fast add/ill framework, after initially adding an item record, including its barcode, when you go back to edit the item record, the barcode field is not editable -- in fact, nothing displays in the barcode field! (see attached) I replicated this behavior using both the Fast Cataloging link under Circulation, and by starting a new record from the Cataloging module using the Fast Add framework. I was able to temporarily resolve this for one of our libraries by having her switch the record framework to default. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Albert Oller <ago@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago@bywatersolutions.com --- Comment #1 from Albert Oller <ago@bywatersolutions.com> 2012-02-29 19:28:03 UTC --- Two other BWS sites have reported this problem: Marlboro College and Three Rivers. Looking into cataloguing/addbiblio.pm first. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |brendan@bywatersolutions.co | |m Severity|minor |critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8649&action=edit Bug 7485 - Cannot edit barcode on Fast Add Simple fix, a special case was added for the fast add framework in the case that an item was being checked out that had not been catalogued. In that case, the barcode was being passed as a parameter through addbiblio.pl to additem.pl. This barcode param was used to overwrite the existing value, so if no barcode param was passed ( which is only the case with fast adds from the circ screen ), the barcode field would appear empty in the items editor. This commit causes that special case code to check for an existing barcode value first, and only use the cgi parameter 'branch' in the case that there is no existing barcode value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8649|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8650&action=edit Bug 7485 - Cannot edit barcode on Fast Add Simple fix, a special case was added for the fast add framework in the case that an item was being checked out that had not been catalogued. In that case, the barcode was being passed as a parameter through addbiblio.pl to additem.pl. This barcode param was used to overwrite the existing value, so if no barcode param was passed ( which is only the case with fast adds from the circ screen ), the barcode field would appear empty in the items editor. This commit causes that special case code to check for an existing barcode value first, and only use the cgi parameter 'branch' in the case that there is no existing barcode value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8650|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8653&action=edit Bug 7485 - Cannot edit barcode on Fast Add Simple fix, a special case was added for the fast add framework in the case that an item was being checked out that had not been catalogued. In that case, the barcode was being passed as a parameter through addbiblio.pl to additem.pl. This barcode param was used to overwrite the existing value, so if no barcode param was passed ( which is only the case with fast adds from the circ screen ), the barcode field would appear empty in the items editor. This commit causes that special case code to check for an existing barcode value first, and only use the cgi parameter 'branch' in the case that there is no existing barcode value. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Editing barcode of fast added item now works. Passes t xt Recommend this for 3.6 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Simple change to a conditional to prevent execution in the cases described. marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|rel_3_8 |rel_3_6 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- patch pushed, and versionned for 3.6, it's a bug, not an ENH -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7485 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org