[Bug 37865] New: Use of uninitialized value $op in string at circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Bug ID: 37865 Summary: Use of uninitialized value $op in string at circulation.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 171182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171182&action=edit Bug 37865: Fix uninitialized value warn Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/circ/circulation.pl line 145.: /home/vagrant/kohaclone/circ/circulation.pl This happened because in cases when $op was undef and circulation.pl tried to directly compare it to string. To reproduce: 1. Go to "Check Out" page of a patron, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warn. 3. Apply patch. 4. Repeat step 1 and check that there's no new "Use of uninitialized value $op" error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 171185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171185&action=edit Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171185|0 |1 is obsolete| | --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 171186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171186&action=edit Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171182|0 |1 is obsolete| | Attachment #171186|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 171187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171187&action=edit Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171187|0 |1 is obsolete| | --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171809&action=edit Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |domm@plix.at |y.org | CC| |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171809|0 |1 is obsolete| | --- Comment #6 from Thomas Klausner <domm@plix.at> --- Created attachment 174257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174257&action=edit Bug 37865: Fix uninitialized value $op warns [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 144. [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 253. These happen in cases when $op is undef and circulation.pl or returns.pl tries to directly compare it to a string. To reproduce: 1. Go to "Check Out" and "Check In" circulation pages, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warning. 3. Apply patch. 4. Repeat step 1 and check that no new "Use of uninitialized value $op" error were logged. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Those vars does not exist in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37865 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org