http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8782 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14289&action=edit Bug 9323: Untranslatable string in serial search Test plan: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14298&action=edit Bug 9323 [Counter-proposal] Untranslatable string in serials search The translator seems to have a problem with the _() function inside HTML. Rather than move only the translatable string to the <script> block, why not move all of the JavaScript to the <script> tag? This keeps things a little more organized and lets us follow the guideline to always use double quotes with _(). Same test plan as Jonathan's patch: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14307|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15213&action=edit Bug 9323 [Counter-proposal] Untranslatable string in serials search The translator seems to have a problem with the _() function inside HTML. Rather than move only the translatable string to the <script> block, why not move all of the JavaScript to the <script> tag? This keeps things a little more organized and lets us follow the guideline to always use double quotes with _(). Same test plan as Jonathan's patch: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> String is now translatable. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.