[Bug 28220] New: Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Bug ID: 28220 Summary: Exception not caught when importing patrons with invalid attribute type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: rel_21_05_candidate Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Tried to use an invalid attribute type. type=test1 at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What would be the expected behaviour? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I think the exception should be caught, and the behavior the same as with any patron with invalid (non-extended attribute) data. --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #2)
I think the exception should be caught, and the behavior the same as with any patron with invalid (non-extended attribute) data.
Which means? When a new patron is imported with an invalid patron attribute we explode. When the patron's attributes are overwritten during an import, we silently ignore them. Should we, 1. explode (skip the whole patron) in both case or 2. do the job but ignore the invalid attributes? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #3)
(In reply to Tomás Cohen Arazi from comment #2)
I think the exception should be caught, and the behavior the same as with any patron with invalid (non-extended attribute) data.
Which means?
When a new patron is imported with an invalid patron attribute we explode. When the patron's attributes are overwritten during an import, we silently ignore them.
Should we, 1. explode (skip the whole patron) in both case or 2. do the job but ignore the invalid attributes?
My feeling is we've been too loose on how we handle this. I don't think we should go full 'blow it all' for bad attributes, but we should at least report back. I have plans to work on enhancing patron import on the next cycle, and I will add more fine grained control on what's going on, there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #4)
My feeling is we've been too loose on how we handle this.
This sentence tried to say that I think attributes should be treated the same as any other borrowers.* column. Specially those that have constraints (unique, not repeatable, mandatory). We are being more strict about this in the code, and it will start hurting people with bad data, so we shouldn't allow bad data in. This needs some bigger changes in the import workflow, that I mentioned I plan to work on soon. So in the meantime, I would prefer to: - Skip the patron with good error reporting, or - At least skip the bad attributes BUT provide good reporting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What about: 1. unique not being unique? 2. non-rep -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #6)
What about: 1. unique not being unique? 2. non-rep
"I think attributes should be treated the same as any other borrowers.* column." I think patron import should skip those patrons totally, and report back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120549&action=edit Bug 28220: Deal with merge -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Your patch changes the merge method so it raises an exception. That would be a good start. The caller doesn't wrap things in a try/catch block yet, but I'm wondering: shouldn't we do it all inside a transaction for each patron? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120549|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120607&action=edit Bug 28220: Deal with merge -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120608&action=edit Bug 28220: Add tests to import failure expected, we need to add a transaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120609&action=edit Bug 28220: prevent patron to be created if attributes not stored Using a transaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120610&action=edit Bug 28220: Handle InvalidType -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120611&action=edit Bug 28220: Handle NonRepeatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120612&action=edit Bug 28220: Add test for updating an existing patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120613&action=edit Bug 28220: Add more tests * Add the transaction when a patron is created * The changes in merge_and_replace_with prevent the creation of the patron and so the attributes if several non-repeatable attributes are passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120614&action=edit Bug 28220: UI changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please try this patch, I think it covers a lot of cases. Test plan (but be creative!): Use the import patron tool to 1. Create a new patron with: * 1 new normal (non-repeatable, not unique) attribute * several repeatable attribute * unique with unique value => all good 2. Create a new patron with: * several new-repeatable attribute => boom 3. Create a new patron with: * unique with non-unique value => boom 4. Create a new patron with: * an invalid patron attribute type code (does not exist) And do the same for an existing patron (with and without the "preserve patron attributes" option). If an error happened the patron will not be created/modified (attributes and other infos) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Exception not caught when |Exception not caught when |importing patrons with |importing patrons |invalid attribute type | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- And, I should add, don't be afraid by the number of patches or their sizes, most of the changes is adding new unit tests and indentation (for transaction and exception handling). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120607|0 |1 is obsolete| | Attachment #120608|0 |1 is obsolete| | Attachment #120609|0 |1 is obsolete| | Attachment #120610|0 |1 is obsolete| | Attachment #120611|0 |1 is obsolete| | Attachment #120612|0 |1 is obsolete| | Attachment #120613|0 |1 is obsolete| | Attachment #120614|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120783&action=edit Bug 28220: Deal with merge Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120784&action=edit Bug 28220: Add tests to import failure expected, we need to add a transaction Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120785&action=edit Bug 28220: prevent patron to be created if attributes not stored Using a transaction Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120786&action=edit Bug 28220: Handle InvalidType Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120787&action=edit Bug 28220: Handle NonRepeatable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120788&action=edit Bug 28220: Add test for updating an existing patron Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120789&action=edit Bug 28220: Add more tests * Add the transaction when a patron is created * The changes in merge_and_replace_with prevent the creation of the patron and so the attributes if several non-repeatable attributes are passed Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120790&action=edit Bug 28220: UI changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, as you signed this one off, could you please also take a look at signing off the dependency bug as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120783|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120885&action=edit Bug 28220: Deal with merge Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120784|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120886&action=edit Bug 28220: Add tests to import failure expected, we need to add a transaction Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120785|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120887&action=edit Bug 28220: prevent patron to be created if attributes not stored Using a transaction Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120786|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120888&action=edit Bug 28220: Handle InvalidType Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120787|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120889&action=edit Bug 28220: Handle NonRepeatable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120788|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120890&action=edit Bug 28220: Add test for updating an existing patron Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120789|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120891&action=edit Bug 28220: Add more tests * Add the transaction when a patron is created * The changes in merge_and_replace_with prevent the creation of the patron and so the attributes if several non-repeatable attributes are passed Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120790|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120892&action=edit Bug 28220: UI changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wow, that took a while to work through.. really great test coverage here helps with confidence. I've tested it with a few different sets of data and it's all working as expected. Great job Jonathan. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 20.11.x. Fails because t/db_dependent/Koha/Patron/Attribute.t does not exists. This file as been added by Bug 27858. Is it a dependance ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Bug 28220 depends on bug 28293, which changed state. Bug 28293 Summary: Wrong key used in Patrons::Import->generate_patron_attributes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616 [Bug 28616] Add libdata-printer-perl package -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #39)
Does not apply on 20.11.x. Fails because t/db_dependent/Koha/Patron/Attribute.t does not exists. This file as been added by Bug 27858. Is it a dependance ?
Yes, you certainly need bug 27858 and bug 27833 as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27858, 27833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27833 [Bug 27833] Koha::Exceptions::Patron::Attribute::* should have parameters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27858 [Bug 27858] Make Koha::Patron::Attribute->store raise an exception on invalid type/code -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org