[Bug 31281] New: Overdue notices reply-to email address of a branch not respected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Bug ID: 31281 Summary: Overdue notices reply-to email address of a branch not respected Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: nason.bimbe@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The overdue notification email is sent from the correct email address as set up for the branch, however the reply-to email address though set for the branch is not the one used. The email has reply-to address of a different branch and not even the default one as set up in system preferences. Below is set up (however I have renamed the branches and email addresses for the purpose of this bug report). So what happened is the overdue notification was sent using LibraryB email address however the reply-to email address on the notification is the reply-to email address of LibraryA instead of LibraryB one. This is on Koha 21.11.05.000 LibraryA settings Email: librarya@mlibary.whatever Reply-To: librarya@mlibrary.whatever Return-Path: librarya@mlibrary.whatever LibraryA settings Email: libraryb@mlibary.whatever Reply-To: libraryb@mlibrary.whatever Return-Path: libraryb@mlibrary.whatever LibraryC settings Email: libraryc@mlibary.whatever Reply-To: libraryc@mlibrary.whatever Return-Path: libraryc@mlibrary.whatever SysPref setting: KohaAdminEmailAddress: library@library.whatever ReplytoDefault: library@library.whatever -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I recenlty tested this similarly on master and there the correct reply-to was used (but I was missing Sender/return-path). How are you running the overdue notices script? (parameters) How are your overdue notice triggers set up? (do you use a default one or only branch specific?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #2 from Nason Bimbe <nason.bimbe@ptfs-europe.com> --- The cron job is as follows $KOHA_CRON_PATH/automatic_renewals.pl -c --send-notices The Triggers are branch specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #3 from Nason Bimbe <nason.bimbe@ptfs-europe.com> --- Here is the complete set of Cron jobs as set up (Auto renew, fine, overdue notice) $KOHA_CRON_PATH/automatic_renewals.pl -c --send-notices; $KOHA_CRON_PATH/fines.pl; $KOHA_CRON_PATH/overdue_notices.pl -t --frombranch item-homebranch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I've found it. overdue notices uses EnqueueLetter to write the letter to the message_queue: C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $borrowernumber, message_transport_type => $effective_mtt, from_address => $admin_email_address, to_address => join(',', @emails_to_use), } Reading the POD for EnqueueLetter this stands out: * reply_address - optional; The reply address for the notice, defaults to patron->library->reply_to So as we are not supplying the address, it would use the reply-to address of the patron's homebranch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138760&action=edit Bug 31281: Use correct reply-to email when sending overdue mails Overdue emails are either sent from the issuing or the home library of an item. We never use the patron's home library, so the reply-to address must explicitly be set in EnqueueLetter. To test: - Set up 2 branches (A and B) with different email addresses. - Set up an SMTP server for each to use - Set up an overdue notice trigger for the patron category you'll use First letter: 1 day delay, any notice - Check out an item with home branch B to a patron from A - Run the the script with: overdue_notices.pl -t --frombranch item-homebranch overdue_notices.pl -t --frombranch item-issuebranch - Confirm for each setting that the correct email headers have been used. You can see the reply-to address and to-address in the message queue: SELECT * FROM message_queue; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138760|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139016&action=edit Bug 31281: Use correct reply-to email when sending overdue mails Overdue emails are either sent from the issuing or the home library of an item. We never use the patron's home library, so the reply-to address must explicitly be set in EnqueueLetter. To test: - Set up 2 branches (A and B) with different email addresses. - Set up an SMTP server for each to use - Set up an overdue notice trigger for the patron category you'll use First letter: 1 day delay, any notice - Check out an item with home branch B to a patron from A - Run the the script with: overdue_notices.pl -t --frombranch item-homebranch overdue_notices.pl -t --frombranch item-issuebranch - Confirm for each setting that the correct email headers have been used. You can see the reply-to address and to-address in the message queue: SELECT * FROM message_queue; Signed-off-by: Nason Bimbe <nason.bimbe@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tested and signed off by Nason, and then QA'd by myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working great and fixes the problem properly. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can we get this one backported, please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #11)
Can we get this one backported, please?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, this seems to have jumped an rmaint.. this is probably a decent candidate for 21.11.x ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- No worries, I picked it from 21.11.x so it didn't jump. Arthur is experimenting to not update the ticket until the very release date. Then it is possible to use the scripts in release-tools to mass-update the bugs included in the release without taking the risks of forgetting one. I feel that can cause issues as one does not subscribe to the tickets and will miss a regression uncovered and request to revert. And people wouldn't even make the request (in-ticket or via direct email) to revert if there is no message from the RMaint that they backported it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree it makes things a bit easier if we see right away if something has already been picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41393 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org