[Bug 17915] New: warning in Stage MARC records for import when matching rule with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 Bug ID: 17915 Summary: warning in Stage MARC records for import when matching rule with offset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org When using Stage MARC records for import with a matching rule where an offset is defined, the input string may be empty or shorter than the offset. This generated a warning : stage-marc-import.pl: substr outside of string at /home/koha/src/C4/Matcher.pm line 822. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 59069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59069&action=edit Bug 17915 - warning in Stage MARC records for import when matching rule with offset When using Stage MARC records for import with a matching rule where an offset is defined, the input string may be empty or shorter than the offset. This generated a warning : stage-marc-import.pl: substr outside of string at /home/koha/src/C4/Matcher.pm line 822. Test plan : - define a matching rule on ISBN with length 0 and offset 999 (too big for any value) - import some MARC records with this matching rule - check the perl warns => Without patch you see warns : "substr outside of string at /home/koha/src/C4/Matcher.pm" => With patch no such warn - edit the matching rule to set offset 0 - import some MARC records, with matching ISBN, with this matching rule => Import must match existing records with same ISBN -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I can't reproduce this problem in master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I was able to reproduce this problem in master, and the patch does make the error go away. However, I'm seeing a different error now: stage-marc-import.pl: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /home/vagrant/kohaclone/Koha/Objects.pm line 92 Is this error within the scope of this bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #3)
I was able to reproduce this problem in master, and the patch does make the error go away. However, I'm seeing a different error now:
stage-marc-import.pl: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /home/vagrant/kohaclone/Koha/Objects.pm line 92
Is this error within the scope of this bug?
Oh could you test again please ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org