[Bug 18305] New: Invalid JS breaks advanced marc editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Bug ID: 18305 Summary: Invalid JS breaks advanced marc editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Get the following errors editing a bibliographic record: "Uncaught SyntaxError: Unexpected token =" and "addbiblio.pl:294 Uncaught TypeError: $(...).fixFloat is not a function" which breaks the advanced MARC editor (and potentially other things as well). This is caused by the following line in koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.fixFloat.js: "$.fn.fixFloat = function (options={}) {" I'm running Chromium 47 which does not support parameter defaults (added in 49). Internet Explorer (besides edge) and Opera has no support. Since everything seems to work fine when fixing this it seems a shame to let this minor snippet screw up support for so many browser versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Invalid JS breaks advanced |jquery.fixFloat.js breaks |marc editor |advanced MARC editor for | |some browsers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 61303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61303&action=edit Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |glasklas@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- *** Bug 17878 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61303|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 61474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61474&action=edit Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61474|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61488&action=edit Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400 [Bug 16400] Proposal to uniform the placement of submit buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the 17.05 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Great! Thanks for the quick response! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for the patch David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- *** Bug 18353 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org