https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73423&action=edit Bug 20495: Remove get_saved_report To test: 1 - prove t/db_dependent/Reports/Guided.t 2 - grep "get_saved_report" - ensure there are no occurences of the singular form 3 - create, save, edit, and convert a report 4 - access a public report and report json from opac and staff client 5 - Ensure all function as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74868&action=edit Bug 20495: Follow up to refactor tools/scheduler TEST PLAN --------- This doesn't require the other patch applied. -- Make sure you have at least 2 saved reports. If you create them from an empty DB, they are 1 and 2 otherwise, you'll need to know their ID numbers. Home -> Tools -> Task Scheduler -- The Report Dropdown has content! localhost:8081/cgi-bin/koha/tools/scheduler.pl?id=1 -- The Report Dropdown is non-empty and correctly selected -- Attempt with id=2, different report selected. apply this patch restart_all Home -> Tools -> Task Scheduler -- Report dropdown has same content! localhost:8081/cgi-bin/koha/tools/scheduler.pl?id=1 -- The Report Dropdown is non-empty and correctly selected -- Attempt with id=2, different report selected. -- effectively no change. run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73423|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74869&action=edit Bug 20495: Remove get_saved_report To test: 1 - prove t/db_dependent/Reports/Guided.t 2 - grep "get_saved_report" - ensure there are no occurences of the singular form 3 - create, save, edit, and convert a report 4 - access a public report and report json from opac and staff client 5 - Ensure all function as expected NOTE: rebased and fixed typo "fund" vs. "find" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #4)

Nick, could you confirm that compound reports are not possible? I think one of your changes is valid, but pointless.

I jumped back to 3.0.x and: git grep "Create Compound Report" only displays in guided reports once! If you can't create compound reports, then you can't save them. I think I'll create a bug to remove those parts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74869|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 74870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74870&action=edit Bug 20495: Remove get_saved_report To test: 1 - prove t/db_dependent/Reports/Guided.t 2 - grep "get_saved_report" - ensure there are no occurences of the singular form 3 - create, save, edit, and convert a report 4 - access a public report and report json from opac and staff client 5 - Ensure all function as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75654&action=edit Bug 20495: (follow-up) Correct search for report by name Ultimately we should probably remove name access as it is not a unique id, but this should preserve existing behaviour To test: Create a report Use the service link to confirm the report runs Replace id=# parameter with name=XXXXXX Confirm URL works -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75653|0 |1 is obsolete| | Attachment #75654|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75716&action=edit Bug 20495: Remove get_saved_report To test: 1 - prove t/db_dependent/Reports/Guided.t 2 - grep "get_saved_report" - ensure there are no occurences of the singular form 3 - create, save, edit, and convert a report 4 - access a public report and report json from opac and staff client 5 - Ensure all function as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.