[Bug 33463] New: 'Actions' column on plugins table should not be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Bug ID: 33463 Summary: 'Actions' column on plugins table should not be sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The last column in the plugins table is 'Actions' and should not be sortable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151066&action=edit Bug 33463: Remove sort for 'Actions' on the plugins table Test plan: Go go the plugin admin page upload a plugin Notice that the "Actions" column is not longuer sortable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like there are much more occurrences. git grep 'Actions</th>'|grep -v NoSort We should fix them all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #2)
Looks like there are much more occurrences.
git grep 'Actions</th>'|grep -v NoSort
We should fix them all.
I have checked a few and I think there is other mark-up there to prevent them from being sorted sometimes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <th class="noExport">Actions</th> Action column on vendor search is NOT sortable. koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt:<th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt: <th>Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt: <th class="noExport">Actions</th> Actions IS sortable. koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/credit_types.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt: <th class="noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt: <th data-class-name="actions noExport">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt: <th class="noExport">Actions</th> Table is not sortable at all. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt: <th>Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt: <th class="noExport">Actions</th> Table is not sortable at all. koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt: <th scope="col">Actions</th> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <th class="noExport">Actions</th> Actions is NOT sortable. I feel this might be a nice excercise for maybe a newbiew/intro session as they require taking a closer look maybe? I feel we can still push this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151066|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151174&action=edit Bug 33463: Remove sort for 'Actions' on the plugins table Test plan: Go go the plugin admin page upload a plugin Notice that the "Actions" column is not longuer sortable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33730 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Filed: Bug 33730 - Action column should not be sortable Easy fix, excercising QAM super powers here: PQA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org