[Bug 22631] New: Make links on barcode on hold summary page consistent (bug 21070)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Bug ID: 22631 Summary: Make links on barcode on hold summary page consistent (bug 21070) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 21070 Target Milestone: --- Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87371&action=edit Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Hold requests CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87371|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87408&action=edit Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87408|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen@inlibro.com> --- Created attachment 87453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87453&action=edit Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87453|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87506&action=edit Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice fix, no regressions.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22631 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Severity|minor |enhancement Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org