[Bug 14135] New: Local Use syspref addition form missing variable type 'Free'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Bug ID: 14135 Summary: Local Use syspref addition form missing variable type 'Free' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSource. But there is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 38816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38816&action=edit Bug 14135 [ENH] Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Uplo There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- This is not an enhancement. It's a bug fix, since Free should have been there in the first place. This is not adding anything new (another type) that wasn't there before, nor is it brand new functionality. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |indradg@gmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Obviously, Indranil Das Gupta is the bug taker, not Owen Leonard. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38816|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38903&action=edit Bug 14135 Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Discovered that there is no validation on the type field. However, that is beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #5 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to M. Tompsett from comment #3)
Obviously, Indranil Das Gupta is the bug taker, not Owen Leonard. :)
Ack! thanks for the cluebat! :P -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38903|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #6 from Amit <amitddng135@gmail.com> --- Created attachment 39206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39206&action=edit Bug 14135 - Local Use syspref addition form missing variable type 'Free' Bug 14135 Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. - No issue found in patch work fine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just a dumb question: What happens if you translate the staff client with these pref types here? Clicking on a translation would still work (insert the original English), but would the user understand? Should we not convert this text box to a select now ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marcel de Rooy from comment #7)
Just a dumb question: What happens if you translate the staff client with these pref types here? Clicking on a translation would still work (insert the original English), but would the user understand? Should we not convert this text box to a select now ?
Actually, that is a valid point. Converting to a drop down selection list would be better. That would also prevent the entry of invalid types. My sign off was to encourage development. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39206|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39407&action=edit Bug 14135 [ENH] Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Uplo There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Discovered that there is no validation on the type field. However, that is beyond the scope of this bug. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39407|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39408&action=edit Bug 14135: Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSource. There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Discovered that there is no validation on the type field. However, that is beyond the scope of this bug. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: See comments above. I would prefer a select instead of adding more text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could switch this to a select on a separate bug? I wonder why it wasn't one in the first place - maybe to allow adding of new types? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #12)
Maybe we could switch this to a select on a separate bug?
I agree. :) This is a good temporary step. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #14 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to comment #11, comment #12 and comment #13) Hi Katrin / Marcel / Mark, my thoughts - bug 14135 fixes a bug, whereas what you all want is an enhancement. 1/ should the QA manager and RM agree, then lets push this into master 2/ open a new bug which proposes to move to a select 3/ have the types read off (perhaps) a yaml file. less hardcoding, more manageable. I've the patch ready for that. what say you? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Indranil Das Gupta from comment #14)
I've the patch ready for that. what say you?
Yes. Less talk more bug creation. I need a sign off. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Agreeing to 1 and 2. 3 seems a bit overkill as it seems not very likely that we are going to add more types at the moment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Indranil Das Gupta from comment #14)
(In reply to comment #11, comment #12 and comment #13)
Hi Katrin / Marcel / Mark,
my thoughts - bug 14135 fixes a bug, whereas what you all want is an enhancement.
1/ should the QA manager and RM agree, then lets push this into master
2/ open a new bug which proposes to move to a select
3/ have the types read off (perhaps) a yaml file. less hardcoding, more manageable.
I've the patch ready for that. what say you?
Indranil: Do not keep your patches there, submit them :) I agree with Katrin about point 3. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14268 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #18 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to comment #8, comment #11 and comment #16) New dropdown enhancement patch at Bug 14268 Note: has bug 14135 as dependency -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #19 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Marcel de Rooy from comment #17)
(In reply to Indranil Das Gupta from comment #14)
(In reply to comment #11, comment #12 and comment #13) <snipped> 3/ have the types read off (perhaps) a yaml file. less hardcoding, more manageable.
I've the patch ready for that. what say you?
Indranil: Do not keep your patches there, submit them :) I agree with Katrin about point 3.
Ok! so I'm in a loop here again. Based on 14135, we have the following list - 'Free', 'Choice', 'YesNo', 'Integer', 'Textarea', 'Float', 'Themes', 'Languages', 'Upload' and 'ClassSources' On a hunch, I decided to fire `SELECT DISTINCT type FROM systempreferences`. What is got back was : Choice, YesNo, Free, Textarea, multiple, Integer, ClassSources, Languages, File, Themes, NULL, short I can see the 1-to-1 mapping for most of the types, but not all. Can someone take a look and comment? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Indranil Das Gupta from comment #19)
Ok! so I'm in a loop here again. ... we have the following list - 'Free', 'Choice', 'YesNo', 'Integer', 'Textarea', 'Float', 'Themes', 'Languages', 'Upload' and 'ClassSources'
On a hunch, I decided to fire `SELECT DISTINCT type FROM systempreferences`. What is got back was : Choice, YesNo, Free, Textarea, multiple, Integer, ClassSources, Languages, File, Themes, NULL, short
I can see the 1-to-1 mapping for most of the types, but not all. Can someone take a look and comment?
I can confirm seeing 'multiple', 'File', '', and 'short'. I believe this is beyond the scope of this patch, though it may merit a clean up bug report. No need to comment or reply on this bug any further. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Indranil! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #23 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #24 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org