[Bug 27279] New: "Checked out by" not populated on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Bug ID: 27279 Summary: "Checked out by" not populated on issuehistory.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Activating the sypref RecordStaffUserOnCheckout, the librarian who checked out the item is not displayed on "Checkout history" tab on biblio view as it's described in release notes for bug 23916. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this will only be available for checkouts after this was turned on (the data is not recorded before). Would you mind testing if that was the issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I've tested this on a sandbox (current version, 21.06) and on our test server (20.11), and the error is valid on both. The setting is turned on. The checked out by information correctly populates in the patron's circulation history, but not in the item checkout history: /cgi-bin/koha/catalogue/issuehistory.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Can confirm this issue exists in 21.05. I performed a checkout AFTER turning on the syspref. I see "Checked out by" in the patron history but not the item history. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 [Bug 23916] Issuer should be recorded and visible in patron circulation history -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125048&action=edit Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] It must have been patron=checkout.issuer as patron-title.inc is expecting a Koha::Patron object, not a borrowernumber. Test plan: Turn RecordStaffUserOnCheckout on Check an item out then in Go to the biblio checkout history and confirm that the "Checked out by" column contains the logged in librarian's name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125048|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 125056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125056&action=edit Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] It must have been patron=checkout.issuer as patron-title.inc is expecting a Koha::Patron object, not a borrowernumber. Test plan: Turn RecordStaffUserOnCheckout on Check an item out then in Go to the biblio checkout history and confirm that the "Checked out by" column contains the logged in librarian's name. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Very minor quibble, in patron circ history we only show first and last name of the person who did the checkout. In the bib's checkout history we're now showing first name, last name, and cardnumber. Didn't seem worth holding up a signoff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125056|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125330&action=edit Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] It must have been patron=checkout.issuer as patron-title.inc is expecting a Koha::Patron object, not a borrowernumber. Test plan: Turn RecordStaffUserOnCheckout on Check an item out then in Go to the biblio checkout history and confirm that the "Checked out by" column contains the logged in librarian's name. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org