[Bug 12460] New: Search history: Combine to start a new search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Bug ID: 12460 Summary: Search history: Combine to start a new search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Depends on: 11430 Allow to start a new search from multiple search history lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 29102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29102&action=edit Bug 12460: Allow to start a new search from multiple search history lines This patch regroups searches of current and previous sessions to allow selecting lines from both groups. It adds a new column (session date) to allow to differentiate searches of current session from other sessions. Patch is for Intranet and OPAC (bootstrap only) Test plan: 1/ Login to intranet interface 2/ Do some biblio searches 3/ Go to the search history page 4/ See you have a new action available "Start a new search", grayed beacause you haven't selected any line 5/ Select two or more searches 6/ "Start a new search" is now enabled, click it. 7/ A dropdown list appears, asking you to chose between a "Match any" search and a "Match all" search. There is also a new column in the table ("Not") allowing you to apply a NOT to the corresponding line. 8/ Make your choice, and then click on Go button, next to the dropdown list. You will be redirected to the catalogue search results. 9/ Confirm that the results are correct. 10/ Set syspref opacthemes to 'bootstrap' 11/ Go to OPAC interface anonymously and repeat steps 2-9 12/ Login to OPAC interface and repeat steps 2-9 13/ Check that authority search history still works as before the patch (except that there is only one table instead of two) Depends on bug 11430 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Trying to test, but Bug 11430 no longer applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia@hotmail.com --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Sent this error message when trying to test: fatal: sha1 information is lacking or useless (C4/Search/History.pm). Setting to 'patch does not apply' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Aleisha Amohia from comment #3)
Sent this error message when trying to test: fatal: sha1 information is lacking or useless (C4/Search/History.pm).
Did you apply the patch for Bug 11430 first? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Rochelle Healy <rochellehealy.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rochellehealy.student@wegc. | |school.nz Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Rochelle Healy <rochellehealy.student@wegc.school.nz> --- We tried applying bug 11430 first but it still doesn't apply, Applying: Bug 12460: Allow to start a new search from multiple search history lines fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12460: Allow to start a new search from multiple search history lines When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12460-Allow-to-start-a-new-search-from-multipl-UuxtJ9.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29102|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35699&action=edit Bug 12460: Allow to start a new search from multiple search history lines Rebased on master Still depends on bug 11430 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om --- Comment #7 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- To add in test plan: Enable syspref EnableSearchHistory before testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com Status|Needs Signoff |Signed Off --- Comment #8 from Pierre Angot <tredok.pierre@gmail.com> --- I've tested it on sandbox. It Works ! ^^ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 LuceBarbey <luce.barbey@cirad.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luce.barbey@cirad.fr --- Comment #9 from LuceBarbey <luce.barbey@cirad.fr> --- I've tested it and I've some comments. 1.This function (developpement) needs a documentation about the behavior. 2. The first time we come on search history, we must select some lines and click on "start a new search" before to see the boolean operator 'NOT'. It's not intuitive 3. To build a complex search, we must proceed in several steps, because we could search only with AND (match all) / OR (match any.) Proposals : 1. Display the "not" column immediately 2. Modify the form : when nothing is checked display "Select searches to run a combined search". When at least one search is checked, display "With selected searches run a combined search [matching any of selected searches] [ok] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 LuceBarbey <luce.barbey@cirad.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35699|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41782&action=edit Bug 12460: Allow to start a new search from multiple search history lines Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14699 Status|In Discussion |Needs Signoff --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on top of bug 14699 It also includes minor changes to address problem 2 of comment 9: - "Start a new search" link is displayed on its own line and doesn't require that the user selected some searches to be "clickable" - Add an alert() popup when user clicks on "Go" without having selected searches. So, the expected user behavior is now: 1/ Click on "Start a new search". (The 'Not' column appears) 2/ Select some searches (optionally toggle the NOT option for some of these) 3/ Click on Go Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 [Bug 14699] Intranet search history issues due to DataTables pagination -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41782|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 42450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42450&action=edit Bug 12460: Allow to start a new search from multiple search history lines Rebased on top of bug 14699 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org