[Bug 27816] New: "Click to edit" in Point of sale is untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Bug ID: 27816 Summary: "Click to edit" in Point of sale is untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The "Click to edit" prompt in "This sale" in the point of sale is untranslatable. To reproduce: 1- Enable EnablePointOfSale syspref 2- Enable UseCashRegisters syspref 3- Set up at least one cash register in Administration > Cash registers 4- Set up at least one Debit type that can be sold through POS in Administration > Debit types 5- Install at least one other language in your staff interface and switch to that language 6- Go to Point of sale and click Add next to one item for purchase 7- On the right hand side where the purchased item is added, click on the price to change it 8- Remove all digits; the click to edit prompt appears in English Is is the same for the Quantity. I checked po/fr-CA-staff-prog.po, po/fr-CA-messages.po and po/fr-CA-messages-js.po and the only "Click to edit" is in the preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I had a look into fixing this, but it seems to come from here: koha-tmpl/intranet-tmpl/lib/datatables/datatables.js: * "defaultContent": "Click to edit" I am not sure how to deal with the string in the datatables library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118251&action=edit Bug 27816: "Click to edit" in Point of sale is untranslatable This patch adds an option to the Point of sale jEditable configuration to explicitly set the title attribute to "Click to edit." This will allow the string to be picked up for translation. To test, apply the patch and test that the correct string is translated. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR The "Click to edit" string should already have been translated, so it's not necessary to update the .po file. - Install the updated translation: > perl translate install fr-FR In the staff interface, switch to the language you're testing and open the point of sale page. Add some items for purchase. They should appear in the "This sale" table. Hover your mouse over the values in the "Coût" and "Quantité" columns. You should see the translated string, "Cliquer pour modifier." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice, thanks Owen, I hadn't got to working out where the magic happens for this one yet 😀 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice, thanks Owen, I hadn't got to working out where the magic happens for this one yet 😀 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118251|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118327&action=edit Bug 27816: "Click to edit" in Point of sale is untranslatable This patch adds an option to the Point of sale jEditable configuration to explicitly set the title attribute to "Click to edit." This will allow the string to be picked up for translation. To test, apply the patch and test that the correct string is translated. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR The "Click to edit" string should already have been translated, so it's not necessary to update the .po file. - Install the updated translation: > perl translate install fr-FR In the staff interface, switch to the language you're testing and open the point of sale page. Add some items for purchase. They should appear in the "This sale" table. Hover your mouse over the values in the "Coût" and "Quantité" columns. You should see the translated string, "Cliquer pour modifier." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works perfectly.. going for a straight QA on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.04 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #9)
Enhancement, not backported to 20.05
Actually a bug - fixed the status. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org