[Bug 7121] New: remove comma on items info
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Bug #: 7121 Summary: remove comma on items info Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All URL: /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=608 0 OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org When looking at the items tab in the staff client, the comma between the 245$a and the 245$b causes things to look a bit messy sometimes. I think we can safely remove that comma and it will greatly improve the display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-11-11 17:01:35 UTC --- Created attachment 6288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6288 Proposed fix Because I can't just take out one comma, I reworked the way moredetail.pl fetches and outputs biblio data based on the way it does in detail.pl. This allows for simpler output in the template. In the process I've added subtitle information to the template. The before and after the patch the display should look the same except for the change in the way author and subtitle are displayed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6288|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-11-11 17:05:49 UTC --- Created attachment 6289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6289 Revised fix Revision adds line break for readability -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6289|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 17:17:30 UTC --- Created attachment 6291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6291 [SIGNED-OFF] Fix for Bug 7121 - remove comma on items info Because I can't just take out one comma, I reworked the way moredetail.pl fetches and outputs biblio data based on the way it does in detail.pl. This allows for simpler output in the template. In the process I've added subtitle information to the template. Revision adds line break for readability -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-11-11 18:00:20 UTC --- this patch requires keyword to marc mappings for subtitles: so: subtitle 245 $b subtitle 245 $p subtitle 245 $n -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2011-11-11 18:02:04 UTC --- sorry that should be as follows: subtitle 245 b parts 245 p number 245 n medium 245 h -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 18:16:00 UTC --- But it works without the mapping as well - it just doesn't show the subtitle, which it didn't show before so this patch is an improvement over the way it was. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 --- Comment #7 from Liz Rea <wizzyrea@gmail.com> 2011-11-11 19:16:24 UTC --- except he explicitly stated that he made a change to the subtitle display, which you can't test without the mappings. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 19:22:27 UTC --- I'm confused. Are you asking for more tests? Or saying it doesn't work, cause it looks to me like my mappings are showing up right. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> 2011-11-11 19:45:34 UTC --- No, what I'm saying is, that the subtitle view won't work unless you have the mapping. When I went to test it, I missed that you had already signed off on it, and in my install the subtitles weren't showing up, which led me to dig deeper. Since the bug states that subtitles are supposed to show on moredetail.pl, I asked about the circumstances of their display, and found out that for the subtitles to display, you have to have the mappings. I added them, and the subtitles were displayed. I would have considered it reasonable to overturn your signoff had I not been able to make the subtitles work in my test install, but since my testing shows they are ok with proper configuration, I don't see a problem with letting it stand and concur with your findings that the patch is ok for inclusion. The note also serves as a heads up for QA, who may or may not have the mappings in their system. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Patch Pushed --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-13 16:33:31 UTC --- QA comment: prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok perlcritic catalogue/moredetail.pl catalogue/moredetail.pl source OK passed QA patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7121 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org