[Bug 35813] New: When placing a booking, we don't feedback successful placements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Bug ID: 35813 Summary: When placing a booking, we don't feedback successful placements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 29002 We lost this during various rebases I think.. we should let the end user know that the booking was placed successfully rather than just close the modal without any feedback. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161048&action=edit Bbug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm sure this could be prettier.. and I wasn't sure whether the new feedback should disappear after a short timeout. We don't have any form of feedback on modals like this as yet.. we need to come up with a pattern and best practice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When placing a booking, we |When placing a booking, we |don't feedback successful |should feedback successful |placements |placements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161058&action=edit Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161059&action=edit Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Owen :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161058|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161086&action=edit Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161059|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161087&action=edit Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug 34862 is going to make sure we have "messages.inc" included everywhere (the context is CSRF token alert there). It would be nice to have this #transient_result node moved to this include file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sounds like a great plan to me, I'll code it up now on its own bug linked to here and 34862 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161086|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162263&action=edit Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161087|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162264&action=edit Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162265&action=edit Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 [Bug 36374] The bookings modal JS should be tidied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162263|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163561&action=edit Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162264|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163562&action=edit Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162265|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163563&action=edit Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial rebase to put it after the js tidy patch in the queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163561|0 |1 is obsolete| | Attachment #163562|0 |1 is obsolete| | Attachment #163563|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166579&action=edit Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166580&action=edit Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166581&action=edit Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need the double underscore in a .js file, fixed inline. + _("Booking successfully updated") + -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Circulation CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36374 not in 23.11.1x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Bug 35813 depends on bug 36374, which changed state. Bug 36374 Summary: Some of our JS files should stay tidy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36374 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35813 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org