[Bug 41710] New: SearchEngine/Elasticsearch/Search.t does not rollback properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Bug ID: 41710 Summary: SearchEngine/Elasticsearch/Search.t does not rollback properly Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org syspref ElasticsearchIndexStatus_mydb is created in DB and persists after the tests finished. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192013&action=edit Bug 41710: Correctly run tests SearchEngine/Elasticsearch/Search.t in a txn Test plan: 0. Apply this patch and startup ktd with elastic (e.g `--search-engine es7`) 1. prove t/db_dependent/check_sysprefs.t => pass 2. DB cli> SELECT COUNT(*) FROM systempreferences; 3. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4. DB cli> SELECT COUNT(*) FROM systempreferences; => No change, still the same number of sysprefs 5. prove t/db_dependent/check_sysprefs.t => pass 6. Revert this patch or checkout main 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 8. DB cli> SELECT COUNT(*) FROM systempreferences; => One syspref crated (ElasticsearchIndexStatus_mydb) 9. prove t/db_dependent/check_sysprefs.t => fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41682 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192061&action=edit Bug 41710: Correctly run tests SearchEngine/Elasticsearch/Search.t in a txn Test plan: 0. Apply this patch and startup ktd with elastic (e.g `--search-engine es7`) 1. prove t/db_dependent/check_sysprefs.t => pass 2. DB cli> SELECT COUNT(*) FROM systempreferences; 3. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4. DB cli> SELECT COUNT(*) FROM systempreferences; => No change, still the same number of sysprefs 5. prove t/db_dependent/check_sysprefs.t => pass 6. Revert this patch or checkout main 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 8. DB cli> SELECT COUNT(*) FROM systempreferences; => One syspref crated (ElasticsearchIndexStatus_mydb) 9. prove t/db_dependent/check_sysprefs.t => fail Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192061|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192065&action=edit Bug 41710: Correctly run tests SearchEngine/Elasticsearch/Search.t in a txn Test plan: 0. Apply this patch and startup ktd with elastic (e.g `--search-engine es7`) 1. prove t/db_dependent/check_sysprefs.t => pass 2. DB cli> SELECT COUNT(*) FROM systempreferences; 3. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4. DB cli> SELECT COUNT(*) FROM systempreferences; => No change, still the same number of sysprefs 5. prove t/db_dependent/check_sysprefs.t => pass 6. Revert this patch or checkout main 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 8. DB cli> SELECT COUNT(*) FROM systempreferences; => One syspref crated (ElasticsearchIndexStatus_mydb) 9. prove t/db_dependent/check_sysprefs.t => fail Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41710 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org