[Bug 28775] New: Warn when viewing itemtypes.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Bug ID: 28775 Summary: Warn when viewing itemtypes.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Browse to: Administration -> Item types administration [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123249&action=edit Bug 28775: Pass interface to getTranslatedLanguages Don't pass undef for interface, we are on the staff client To test: 1 - Browse to Administration -> Item types administration 2 - See in logs: [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. 3 - Apply patch 4 - Reload page 5 - No warn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123249|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123345&action=edit Bug 28775: Pass interface to getTranslatedLanguages Don't pass undef for interface, we are on the staff client To test: 1 - Browse to Administration -> Item types administration 2 - See in logs: [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. 3 - Apply patch 4 - Reload page 5 - No warn Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the case of release notes| |unnecessary warning | |messages in the log files | |when accessing the | |Administration > Item types | |page in the staff | |interface. | | | |Before this, | |multiple warning messages | |"[WARN] Use of | |uninitialized value | |$interface in concatenation | |(.) or string at | |/kohadevbox/koha/C4/Languag | |es.pm line 121." appeared | |in the log files. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the case of |This fixes the cause of release notes|unnecessary warning |unnecessary warning |messages in the log files |messages in the log files |when accessing the |when accessing the |Administration > Item types |Administration > Item types |page in the staff |page in the staff |interface. |interface. | | |Before this, |Before this |multiple warning messages |fix, multiple warning |"[WARN] Use of |messages "[WARN] Use of |uninitialized value |uninitialized value |$interface in concatenation |$interface in concatenation |(.) or string at |(.) or string at |/kohadevbox/koha/C4/Languag |/kohadevbox/koha/C4/Languag |es.pm line 121." appeared |es.pm line 121." appeared |in the log files. |in the log files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- It seems to me that this fix is too easy. Can be translated may well pertain to the OPAC (not staff only). For instance we use staff in English, but OPAC in Dutch and English. If you look at the module routine, you see that no interface means OPAC + Intranet in returned languages. Giving another result in the above scenario. Please adjust the routine? Passing empty string might be a cheap solution but probably not the nicest ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 29040 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org