[Bug 17844] New: Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Bug ID: 17844 Summary: Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58585&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58586&action=edit Bug 17844: Remove C4::Koha::get_notforloan_label_of -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #1)
=> The staff description of NFL1 will always be used, even for the OPAC
I find that after applying the patch the OPAC description is used on the place hold page instead of the staff one. I also find that the staff client search results page shows the NFL1 description for both records. The OPAC shows the NFL2 description for both records when placing an item-level hold. Very confusing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58585|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58601&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #3)
(In reply to Jonathan Druart from comment #1)
=> The staff description of NFL1 will always be used, even for the OPAC
I find that after applying the patch the OPAC description is used on the place hold page instead of the staff one.
Arg, stupid c/p from the opac-reserve.pl script. Fixed!
I also find that the staff client search results page shows the NFL1 description for both records.
Yes, I guess we have this problem on several different places. I would prefer to stick on the get_notforloan_label_of removing and address a complete fix on another bug report, if it makes sense.
The OPAC shows the NFL2 description for both records when placing an item-level hold.
I do not recreate that, could you double check or detail? On /cgi-bin/koha/opac-reserve.pl?biblionumber=1, when I click "show more options" then "A specific item", I see the correct AV opac description (depending on what is defined in the framework) in the "information" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58586|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60012&action=edit Bug 17844: Remove C4::Koha::get_notforloan_label_of Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58601|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60013&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60012|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60980&action=edit Bug 17844: Remove C4::Koha::get_notforloan_label_of Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60013|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 60981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60981&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org