https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 135018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135018&action=edit Bug 30775: Make 952w to have datepicker plugin by default This field (Price effective from) is very similar to 952d, but it doesn't have dateaccessioned.pl plugin by default, Apart of worse usability of this it is also allows to enter wrong date which will be converted in 0000-00-00 in DB and even lead to crashes by code in other places. So, adding this plugin not only improves usability (user can have datepicker) but also adds date field validation. Test plan: 1. Head over to MARC frameworks from your administration page, check 952 subfield structure of your default framework structure. 2. dateaccessioned.pl is set as a plugin for 952d by default but is missing from 952w. 3. Apply the patch and reset your koha, drop db and use reset_all alias. 4. Check frameworks structure again and ensure that datepicker plugin is set by default for 952w. 5. Edit some item to ensure that datepicker works for that 952w. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135018|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135461&action=edit Bug 30775: Make 952w to have datepicker plugin by default This field (Price effective from) is very similar to 952d, but it doesn't have dateaccessioned.pl plugin by default, Apart of worse usability of this it is also allows to enter wrong date which will be converted in 0000-00-00 in DB and even lead to crashes by code in other places. So, adding this plugin not only improves usability (user can have datepicker) but also adds date field validation. Test plan: 1. Head over to MARC frameworks from your administration page, check 952 subfield structure of your default framework structure. 2. dateaccessioned.pl is set as a plugin for 952d by default but is missing from 952w. 3. Apply the patch and reset your koha, drop db and use reset_all alias. 4. Check frameworks structure again and ensure that datepicker plugin is set by default for 952w. 5. Edit some item to ensure that datepicker works for that 952w. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135461|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136152&action=edit Bug 30775: Make 952w to have datepicker plugin by default This field (Price effective from) is very similar to 952d, but it doesn't have dateaccessioned.pl plugin by default, Apart of worse usability of this it is also allows to enter wrong date which will be converted in 0000-00-00 in DB and even lead to crashes by code in other places. So, adding this plugin not only improves usability (user can have datepicker) but also adds date field validation. Test plan: 1. Head over to MARC frameworks from your administration page, check 952 subfield structure of your default framework structure. 2. dateaccessioned.pl is set as a plugin for 952d by default but is missing from 952w. 3. Apply the patch and reset your koha, drop db and use reset_all alias. 4. Check frameworks structure again and ensure that datepicker plugin is set by default for 952w. 5. Edit some item to ensure that datepicker works for that 952w. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.