[Bug 10320] New: Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Bug ID: 10320 Summary: Show results from library's OverDrive collection in OPAC search Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P4 Component: OPAC Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com Show any relevant results from OverDrive on the OPAC search. This is done by showing a link with "Found xx results in the library's OverDrive collection" at the top of opac-search.pl, and linking to a page that shows the full results. This requires an OverDrive developer account. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 18360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18360&action=edit Bug 10320 - Integrate OverDrive search into OPAC (1/2) This show results from the OverDrive ebook/audiobook service in the OPAC. To test: 1) Fill in the OverDrive system preferences (you will need an Overdrive client key, client secret and library ID). 2) Perform a search on the OPAC, verify that, if available, a link to results from OverDrive will appear at the top. 3) Click on the link, verify that the list of results appears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 18361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18361&action=edit Bug 10320 - Integrate OverDrive search into OPAC (2/2) This followup adds the sysprefs and copies the relevant JS to CCSR. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- A few remarks (you may choose to ignore): _request(): * you are only logging die() case, it may be good to log $response->as_string if !$response->success. GetOverDriveToken(): * m!! (or similar) is a tad easier to read then m,, * in warn $contents->{'error_description'} it is assumed that from_json() was successful Please let me know if you want to leave as is, I'll sign it off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 18687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18687&action=edit Bug 10320 - Integrate OverDrive search into OPAC (1/2) This show results from the OverDrive ebook/audiobook service in the OPAC. To test: 1) Fill in the OverDrive system preferences (you will need an Overdrive client key, client secret and library ID). 2) Perform a search on the OPAC, verify that, if available, a link to results from OverDrive will appear at the top. 3) Click on the link, verify that the list of results appears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18360|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18361|0 |1 is obsolete| | Attachment #18687|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18688&action=edit [SIGNED-OFF] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Signed off without actually testing new functionality - was not able to obtain OverDrive key. OPAC search seems fine with the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 hbankhead@losgatosca.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbankhead@losgatosca.gov --- Comment #7 from hbankhead@losgatosca.gov --- Henry Bankhead from Los Gatos Library tested this with our overdrive key and it works! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Thanks for that, I declare it signed-off for real. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18688|0 |1 is obsolete| | --- Comment #9 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 18970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18970&action=edit [Signed off] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Henry Bankhead <hbankhead@losgatosca.gov> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10486 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18970|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19225&action=edit Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Henry Bankhead <hbankhead@losgatosca.gov> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but I think there are various problems with this: - It missed unit tests for the new module. - It introduces untranslatable strings in the Javascript. - It should probably be using the sprite for displaying the stars (Owen has done work on having Babeltheque and the opacstarratings using it, so there are already star images available I think) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #12 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 19493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19493&action=edit Bug 10320 followup - Fix translation/CSS issues This switches to the alternate method of displaying stars, and makes the strings in the OverDrive JS translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- I got this error after doing a search: overdrive_proxy: Can't call method "set_in_cache" on an undefined value at /home/oleonard/kohaclone/C4/External/OverDrive.pm line 125 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #14 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 19773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19773&action=edit Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- The first patch has a typical updatedatabase conflict. The second fails with this error: fatal: sha1 information is lacking or useless (C4/External/OverDrive.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Followup for bug 10320: minor bugfixes and style improvements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19225|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 19774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19774&action=edit Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Henry Bankhead <hbankhead@losgatosca.gov> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19773|0 |1 is obsolete| | --- Comment #17 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 19775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19775&action=edit Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19774|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19884&action=edit [SIGNED-OFF] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Henry Bankhead <hbankhead@losgatosca.gov> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19775|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19885&action=edit [SIGNED-OFF] Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- These patches work well in my tests. One minor thing needs a follow-up: Some of the copyright statements on the new scripts appear to be copypasta. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks nice and works well afaikt :) I am adding my passed QA to these patches, but we need a follow up: Please run the QA script and fix following problems and also the copyright statements Owen pointed out: FAIL C4/External/OverDrive.pm FAIL pod *** ERROR: =item without previous =over in file C4/External/OverDrive.pm FAIL koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt FAIL forbidden patterns forbidden pattern: tab char (line 143) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 34) forbidden pattern: tab char (line 148) Also I'd think it would be nice to have a non-Javascript fall back. For example you could prodie a simple search link in case Javascript is disabled in the browser. Please switch back to signed off when the follow up is ready and I will take a final look (or someone else who beats me to it :) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19884|0 |1 is obsolete| | Attachment #19885|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19886&action=edit [PASSED QA] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Henry Bankhead <hbankhead@losgatosca.gov> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19887&action=edit [PASSED QA] Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #24 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 19989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19989&action=edit QA followup for bug 10320 - Fix copyright and style errors This patch fixes a copypasta'd copyright statement, and some incorrect POD and indentation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #25 from Jesse Weaver <jweaver@bywatersolutions.com> --- There's still a QA error, but talking with Owen, I believe that it's specious. The test is intended to remove /prog/ hardcoding, but the lines mentioned use the generic /opac-tmpl/lib directory. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19989|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20024&action=edit [PASSED QA] QA followup for bug 10320 - Fix copyright and style errors This patch fixes a copypasta'd copyright statement, and some incorrect POD and indentation. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #27 from Galen Charlton <gmcharlt@gmail.com> --- Koha's license is GPL3+, not GPL2+. I also assume that opac/opac-overdrive-search.pl is copyright 2013 ByWater, not 2009 BibLibre. I will not push this without clarification of the licensing. I am willing to make the necessary follow-up patch to correct the headers, but I need somebody from ByWater to make the following confirmations in this bug: [1] That ByWater is licensing the code as GPL3+. [2] Whether opac/opac-overdrive-search.pl is actually copyright 2013 by ByWater. Setting to Failed QA pending those confirmations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #28 from Jesse Weaver <jweaver@bywatersolutions.com> --- Confirmed with Brendan. Yes, this code is all licensed under GPLv3+ and copyright 2013 ByWater. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with follow-ups to correct the license, a typo in the name of one of the system preference, adding the new sysprefs to sysprefs.sql, and handling OverDrive authentication failures encountered by the proxy service a tick more gracefully than by tossing an internal server error. Thanks, Jesse! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11959 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org