[Bug 33933] New: Use restrictions appear twice for items on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Bug ID: 33933 Summary: Use restrictions appear twice for items on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Bug 32611 fixed a problem with restricted_lib and notforloan_lib not being set correctly. However, it also introduced another span.restricted, when that information is already shown next to "Available". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 [Bug 32611] Not for loan items don't show the specific not for loan value in OPAC detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 152073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152073&action=edit Bug 33933: Only show use restriction once on OPAC detail page This patch removes a regression from bug 32611 that caused the use restriction text to be shown twice for "Available" items. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=29 2. Edit item and add "Restricted access" for "5 - Use restrictions" 3. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 4. Note that "Status" says "Available (Restricted access)" and there is no duplicate "Restricted access" at the top of that table cell -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It looks correct but I am not confident in signing it off. The code is confusing! How did we miss that on bug 32611? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #2)
It looks correct but I am not confident in signing it off. The code is confusing!
I agree the code is confusing. At some point, I think we need to move more of this status information lower in the code, so that we're showing the same thing via all controllers (e.g. detail page, API, ILS-DI, etc).
How did we miss that on bug 32611?
I think only the "Not for loan" was tested. Since "Not for loan" turns off "Available", this regression wouldn't have appeared during testing. That said, bug 32611 says "The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value." I don't think that's true, as I've been using use restrictions for quite a few years, and they've shown up for "available" items. (Many of my libraries use "Photocopy only" or "Electronic" use restrictions.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Then again... if we look at C4::Circulation::CanBookBeIssued, we can see the following: if ( $item_object->restricted && $item_object->restricted == 1 ) { $issuingimpossible{RESTRICTED} = 1; } So if you can't check it out, it probably shouldn't say "Available"... Item status drives me a little crazy... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Available can be on the shelf... usable in the library, not necessarily for loan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #5)
Available can be on the shelf... usable in the library, not necessarily for loan.
Mmm that's true and I think that's how we've been using it for years in our libraries. I think the search results say "Available for loan", although I've customized that locally to things like "Available electronically" or "Available for photocopy" depending on the use restriction... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152073|0 |1 is obsolete| | --- Comment #7 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 152901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152901&action=edit Bug 33933: Only show use restriction once on OPAC detail page This patch removes a regression from bug 32611 that caused the use restriction text to be shown twice for "Available" items. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=29 2. Edit item and add "Restricted access" for "5 - Use restrictions" 3. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 4. Note that "Status" says "Available (Restricted access)" and there is no duplicate "Restricted access" at the top of that table cell Signed-off-by: ebal <eric.balluto@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Eric Balluto <eric.balluto@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |eric.balluto@univ-lyon2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #8 from Eric Balluto <eric.balluto@univ-lyon2.fr> --- marked signed off as the test plan was successfull. The question of the code quality is left to the QA step. The bug doesn't need to be in the need SO queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152901|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153217&action=edit Bug 33933: Only show use restriction once on OPAC detail page This patch removes a regression from bug 32611 that caused the use restriction text to be shown twice for "Available" items. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=29 2. Edit item and add "Restricted access" for "5 - Use restrictions" 3. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 4. Note that "Status" says "Available (Restricted access)" and there is no duplicate "Restricted access" at the top of that table cell Signed-off-by: ebal <eric.balluto@univ-lyon2.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org