[Bug 17296] New: Failed to correctly configure AnonymousPatron with AnonSuggestions gives Software error in new purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Bug ID: 17296 Summary: Failed to correctly configure AnonymousPatron with AnonSuggestions gives Software error in new purchase suggestion Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: miguel.tuimil@xercode.es QA Contact: testopia@bugs.koha-community.org If the preference AnonSuggestions is changed to Allow and AnonymousPatron is left in default (0), when an unauthenticated patron send a new purchase suggestion using the form (opac-suggestions.pl?op=add) appear: Software error: DBIx::Class::ResultSet::create(): Column 'suggestedby' cannot be null at /usr/share/koha/lib/C4/Suggestions.pm line 457 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |14655 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 [Bug 14655] Cannot checkin without Anonymous Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Version|16.05 |unspecified Status|NEW |ASSIGNED Severity|minor |normal --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's a configuration issue, you should get a warning in the about page, but something is buggy. Patch is coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55554&action=edit Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Failed to correctly |Failed to correctly |configure AnonymousPatron |configure AnonymousPatron |with AnonSuggestions gives |with AnonSuggestions should |Software error in new |display a warning in about |purchase suggestion | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55554|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 55555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55555&action=edit Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55555|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55653&action=edit [PASSED QA] Bug 17296: Display warning if AnonymousPatron is not correctly set Bug 14655 added a warning to the about page ("System information" tab) if the AnonymousPatron feature is not correctly configured. But actually there is one case when it's not displayed. Test plan: Set AnonymousPatron to a non existing patron Set at least 1 borrowers.privacy == 2 go on the about page. Without this patch you do not get the warning With this patch you will see "Some patrons have requested a privacy on returning item but the AnonymousPatron pref is not set correctly. Set it to a valid borrower number if you want that this feature works correctly." Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17296 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org