[Bug 36885] New: Missing tooltip on budget planning page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Bug ID: 36885 Summary: Missing tooltip on budget planning page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 34404 It looks like I got halfway to adding a Bootstrap tooltip to the budget planning template for funds which are locked. I added the JS trigger but didn't change the markup to match. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166831&action=edit Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It's a bug in that the feature is half-implemented, an enhancement in that nothing is broken in the current state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166831|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 166924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166924&action=edit Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes: 1. Before the patch, the tooltip has a white background, border, and the text is normal-sized. 2. After the patch, the tooltip text is white text on a black background with rounded corners, with a smaller text size. (That is the only difference I noted). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry to be nit-picky... but as we lock on budget level, should this be "budget locked"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Also being nit-picky :) ...That's how it was before my patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Shouldn't we do what is right? Also it didn't work... ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Happy to make that little change, mostly checking if I am in the wrong or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168209&action=edit Bug 36885: (follow-up) Correct popup hint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Why do we add a tooltip Budget locked in the ELSE part here (when there would be no budget lock) ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, can you please reply to Marcel's question so we can get this moving? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168997&action=edit Bug 36885: (follow-up) Remove tooltip from unlocked budgets (copy-paste error) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166924|0 |1 is obsolete| | Attachment #168209|0 |1 is obsolete| | Attachment #168997|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169186&action=edit Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." Signed-off-by: David Nind <david@davidnind.com> Bug 36885: (follow-up) Correct popup hint Bug 36885: (follow-up) Remove tooltip from unlocked budgets (copy-paste error) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Budget release notes| |locked" tooltip for budget | |fund planning pages | |(Administration > Budgets > | |select a budget that is | |locked > Funds > Planning > | |any planning option). The | |tooltip was not styled | |correctly for fund names - | |it now has white text on a | |black background. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.09 released in| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #17 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org