https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180682|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180713&action=edit Bug 39570: Add item form includes itemnumber while adding a new item Because the template uses the wrong op, add_item rather than cud-additem, to decide whether to include a hidden input with the itemnumber, if you edit an item and then add another item you wind up submitting a form that includes the previous itemnumber when you add a new one. Nothing happens, because the code for adding an item doesn't look at $input->param('itemnumber'), but since it doesn't mean anything we shouldn't be submitting it. Test plan: 1. Without the patch, find any biblio with at least one item attached, and in the items table click Edit item on one of them 2. Without needing to making any changes, click Save changes 3. In the page that loads, scroll down to the bottom of the Add item form, right-click the Add item button, and choose Inspect 4. A few lines up, above a '<fieldset class="action">,' there will be an '<input type="hidden" name="itemnumber" value="633">' with the itemnumber of the item you previously edited 5. Apply patch 6. Scroll up, click Actions - Edit on any item, then Save changes 7. Again, right-click the Add item button, Inspect, note that there isn't a itemnumber input with the number of the item you previously edited Sponsored-by: Chetco Community Public Library Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180713|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 180814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180814&action=edit Bug 39570: Add item form includes itemnumber while adding a new item Because the template uses the wrong op, add_item rather than cud-additem, to decide whether to include a hidden input with the itemnumber, if you edit an item and then add another item you wind up submitting a form that includes the previous itemnumber when you add a new one. Nothing happens, because the code for adding an item doesn't look at $input->param('itemnumber'), but since it doesn't mean anything we shouldn't be submitting it. Test plan: 1. Without the patch, find any biblio with at least one item attached, and in the items table click Edit item on one of them 2. Without needing to making any changes, click Save changes 3. In the page that loads, scroll down to the bottom of the Add item form, right-click the Add item button, and choose Inspect 4. A few lines up, above a '<fieldset class="action">,' there will be an '<input type="hidden" name="itemnumber" value="633">' with the itemnumber of the item you previously edited 5. Apply patch 6. Scroll up, click Actions - Edit on any item, then Save changes 7. Again, right-click the Add item button, Inspect, note that there isn't a itemnumber input with the number of the item you previously edited Sponsored-by: Chetco Community Public Library Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- "Add item form includes itemnumber while adding a new item" => this is the bug commit message should explain the fix like : "Add item form must not include itemnumber while adding a new item" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39570 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.