http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10514 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19796&action=edit Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19796|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19818&action=edit Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19818|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19829&action=edit [PASSED QA] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and passes all tests. Made sure strings can be translated testing with German templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.