[Bug 37854] New: Barcode fails when adding item during order receive (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Bug ID: 37854 Summary: Barcode fails when adding item during order receive (again) Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Basically the same bug as 28103 but newer Koha version, and this time we get "undefined" instead of a console error. -- 0. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 1. Create a vendor 2. Create a backet with "Create items when" set to "receiving an order" 3. Add an order (any order) 4. Close the basket 5. Receive the shipment 6. Click in the barcode field 7. Note that you get a barcode like undefined24090001 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28103 [Bug 28103] Barcode fails when adding item during order receive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- This time it's because the Javascript code written by C4/Barcodes/ValueBuilder.pm only works for the MARC basic editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Fortunately, there's a very simple "fix" for this. Yikes... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #2)
Fortunately, there's a very simple "fix" for this. Yikes...
Oh I take that back. Fixes the Javascript but wrecks the styling :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 171115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171115&action=edit Bug 37854: Add fieldset.rows so that Javascript works This change adds a fieldset.rows that the Javascript produced by C4/Barcodes/ValueBuilder.pm will work here too like it does for /cgi-bin/koha/cataloguing/additem.pl and /cgi-bin/koha/acqui/neworderempty.pl The fieldset.rows element ruins the styling, so we add some context specific styling to the styling is preserved. Test plan: 0. Apply the patch 1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 2. Create a vendor 3. Create a backet with "Create items when" set to "receiving an order" 4. Add an order (any order) 5. Close the basket 6. Receive the shipment 7. Click in the barcode field 8. Note that you get a barcode like CPL24090001 and not undefined24090001 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 171116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171116&action=edit Bug 37854: Re-indent HTML (whitespace-only) This whitespace only change re-indents the HTML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |23.05 Depends on| |8179 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Looking like bug 8179 is what broke this one Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171115|0 |1 is obsolete| | --- Comment #7 from Olivier V <ovezina@inlibro.com> --- Created attachment 171234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171234&action=edit Bug 37854: Add fieldset.rows so that Javascript works This change adds a fieldset.rows that the Javascript produced by C4/Barcodes/ValueBuilder.pm will work here too like it does for /cgi-bin/koha/cataloguing/additem.pl and /cgi-bin/koha/acqui/neworderempty.pl The fieldset.rows element ruins the styling, so we add some context specific styling to the styling is preserved. Test plan: 0. Apply the patch 1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 2. Create a vendor 3. Create a backet with "Create items when" set to "receiving an order" 4. Add an order (any order) 5. Close the basket 6. Receive the shipment 7. Click in the barcode field 8. Note that you get a barcode like CPL24090001 and not undefined24090001 Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171116|0 |1 is obsolete| | --- Comment #8 from Olivier V <ovezina@inlibro.com> --- Created attachment 171235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171235&action=edit Bug 37854: Re-indent HTML (whitespace-only) This whitespace only change re-indents the HTML Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171234|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174546&action=edit Bug 37854: Add fieldset.rows so that Javascript works This change adds a fieldset.rows that the Javascript produced by C4/Barcodes/ValueBuilder.pm will work here too like it does for /cgi-bin/koha/cataloguing/additem.pl and /cgi-bin/koha/acqui/neworderempty.pl The fieldset.rows element ruins the styling, so we add some context specific styling to the styling is preserved. Test plan: 0. Apply the patch 1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 2. Create a vendor 3. Create a backet with "Create items when" set to "receiving an order" 4. Add an order (any order) 5. Close the basket 6. Receive the shipment 7. Click in the barcode field 8. Note that you get a barcode like CPL24090001 and not undefined24090001 Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171235|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174547&action=edit Bug 37854: Re-indent HTML (whitespace-only) This whitespace only change re-indents the HTML Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37854 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED CC| |jesse@bywatersolutions.com Resolution|--- |FIXED --- Comment #14 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org