[Bug 33856] New: Inventory tool CSV export contains untranslatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Bug ID: 33856 Summary: Inventory tool CSV export contains untranslatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 22135 The "Problem" header row label and the problems themselves are untranslatable as they are added in the inventory.pl file. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152078&action=edit Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan: Update po, translate the new strings, install the language, use it for the UI and confirm that the CSV generated has 'problem' column translated gulp po:update --lang LANG vim misc/translator/po/LANG-messages-js.po cd misc/translator; perl translate install LANG -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, might need a little work with my dependent patch (I see yours still has problem instead of Problem) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Patch doesn't apply currently. (In reply to Katrin Fischer from comment #2)
Hm, might need a little work with my dependent patch (I see yours still has problem instead of Problem)
I think this is the first problem. It also doesn't take into account bug 22135 and "shelved out of order" I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152078|0 |1 is obsolete| | --- Comment #4 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 185828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185828&action=edit Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan: Update po, translate the new strings, install the language, use it for the UI and confirm that the CSV generated has 'problem' column translated gulp po:update --lang LANG vim misc/translator/po/LANG-messages-js.po cd misc/translator; perl translate install LANG -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Marion Durand <marion.durand@biblibre.com> --- Patch rebased for master Caution : I was not able to test it as I could not find how to generate the updated po files but I think this is due to my poor knowledge on how to do it. On KTD When I use `gulp po:update --lang fr-FR` It generates new .pot files and update some .po files but the new chains are not in the file. Might be something wrong but I can't figure out what. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 185828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185828 Bug 33856: Make inventory problems translatable Review of attachment 185828: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33856&attachment=185828) ----------------------------------------------------------------- ::: tools/inventory.pl @@ +489,4 @@
if ( $error->{'ERR_BARCODE'} ) { push @line, map { $_ eq 'barcode' ? $error->{'barcode'} : '' } @keys; push @line, "barcode not found"; + push @line, __("barcode not found");
I think you've got a typo there where you didn't delete the untranslated line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- According to the commit message on 8044, it looks like you need to run "./translate update LANG" I think to get the .po files updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185828|0 |1 is obsolete| | --- Comment #8 from Marion Durand <marion.durand@biblibre.com> --- Created attachment 185847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185847&action=edit Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan (assuming KTD): 1- Update po misc/translator/translate update LANG (for example LANG="fr-FR") 2- translate the new strings vim misc/translator/po/LANG-messages-js.po edit for example "wrong place" or "missing" 3- install the language koha-translate --install LANG --dev kohadev 4- use it for the UI and confirm that the CSV generated has 'problem' column translated a- Using the test language (activate it with sysprefStaffInterfaceLanguages) b- Go to Cataloging > Inventory c- Fill some barcode and some filter (for example a filter on callnumber) d- Select "Export to CSV file" e- Submit f- Open the CSV file generated, check that the colomn problem is now translated according to what you have filled in step 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #9 from Marion Durand <marion.durand@biblibre.com> --- Thank you David for your help ! I corrected the typo and updated the commit message to detail more the process. This time I was able to test the patch and I worked well for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- I think the test plan was a bit off.. Revised Test plan (assuming KTD): 0 - Apply the patch and koha-plack --restart kohadev 1- Update po misc/translator/translate update fr-FR 2- translate the new strings vim misc/translator/po/fr-FR-messages.po edit for example "wrong place" or "missing" 3- install the language koha-translate --install fr-FR --dev kohadev 4- use it for the UI and confirm that the CSV generated has 'problem' column translated a- Using the test language (activate it with syspref StaffInterfaceLanguages) b- Go to Cataloging > Inventory c- Fill some barcode and some filter (for example a filter on callnumber) d- Select "Export to CSV file" e- Submit f- Open the CSV file generated, check that the colomn problem is now translated according to what you have filled in step 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Marion Durand from comment #9)
Thank you David for your help !
I corrected the typo and updated the commit message to detail more the process.
This time I was able to test the patch and I worked well for me.
I'm going to say that you've marked this as Signed Off too in this case -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185847|0 |1 is obsolete| | --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 186189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186189&action=edit Bug 33856: Make inventory problems translatable We should make the inventory 'problem' column translatable. Test plan (assuming KTD): 1- Update po misc/translator/translate update LANG (for example LANG="fr-FR") 2- translate the new strings vim misc/translator/po/LANG-messages-js.po edit for example "wrong place" or "missing" 3- install the language koha-translate --install LANG --dev kohadev 4- use it for the UI and confirm that the CSV generated has 'problem' column translated a- Using the test language (activate it with sysprefStaffInterfaceLanguages) b- Go to Cataloging > Inventory c- Fill some barcode and some filter (for example a filter on callnumber) d- Select "Export to CSV file" e- Submit f- Open the CSV file generated, check that the colomn problem is now translated according to what you have filled in step 2 Signed-off-by: Marion Durand <marion.durand@biblibre.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #13 from Marion Durand <marion.durand@biblibre.com> --- Thank you David for your help ! I didn't actually signed it off because I wasn't sure if I could as I rebased the patch. Thanks for adding my signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Marion Durand from comment #13)
Thank you David for your help !
I didn't actually signed it off because I wasn't sure if I could as I rebased the patch. Thanks for adding my signoff
Fair enough! Doesn't hurt to be cautious! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.08 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.04,24.11.08 |25.11.00,25.05.04,24.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- EDIT: 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33856 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #19 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org