[Bug 33169] New: Improve vue breadcrubms and left-hand menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Bug ID: 33169 Summary: Improve vue breadcrubms and left-hand menu Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Jonathan made a great vue component in bug 32030 to build the breadcrumbs from vue-routes, but I believe it can be improved. With this implementation, I believe it will be a little cleaner to define the routes, and besides that, we can use the same definition to build the left-hand side menu. Now if you want to add a new option, there is only one place to modify (the routes definition) and everything else will be built around it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32991 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 [Bug 32991] Improve our Dialog component and remove routes for deletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 147962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147962&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. You forgot the translatability ;) 2. There are 2 warnings in the console Vue received a Component which was made a reactive object. This can lead to unnecessary performance overhead, and should be avoided by marking the component with `markRaw` or using `shallowRef` instead of `ref`. 3. The last item does not have the "current" and so is not styled correctly (green instead of grey) 4. The disabled ("Local" for instance) is also styled differently 5. This will conflict with bug 32932 6. vue/stores/navigation.js should be tidied :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #3 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #2)
1. You forgot the translatability ;)
2. There are 2 warnings in the console
Vue received a Component which was made a reactive object. This can lead to unnecessary performance overhead, and should be avoided by marking the component with `markRaw` or using `shallowRef` instead of `ref`.
3. The last item does not have the "current" and so is not styled correctly (green instead of grey)
4. The disabled ("Local" for instance) is also styled differently
5. This will conflict with bug 32932
6. vue/stores/navigation.js should be tidied :)
Thank you Jonathan for the feedback! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve vue breadcrubms and |Improve vue breadcrumbs and |left-hand menu |left-hand menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148044&action=edit Bug 33169: (follow-up) Cleanup and tidy a little bit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 [Bug 32932] Re-structure Vue router-links to use "name" instead of urls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148044|0 |1 is obsolete| | --- Comment #5 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148081&action=edit Bug 33169: (follow-up) Cleanup and tidy a little bit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147962|0 |1 is obsolete| | Attachment #148081|0 |1 is obsolete| | --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148097&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 [Bug 32607] Add import sources CRUD -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This no longer applies after 32932 has been pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Bug 33169 depends on bug 32991, which changed state. Bug 32991 Summary: Improve our Dialog component and remove routes for deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148097|0 |1 is obsolete| | --- Comment #8 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 149710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149710&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Changed assignee 8-). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149710|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149744&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is something broken. Uncaught (in promise) Error: Missing required param "license_id" To recreate: 1. Create a license 2. Go to /cgi-bin/koha/erm/licenses 3. Click on a license's name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149744|0 |1 is obsolete| | --- Comment #12 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 151530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151530&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #13 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #11)
There is something broken.
Uncaught (in promise) Error: Missing required param "license_id"
To recreate: 1. Create a license 2. Go to /cgi-bin/koha/erm/licenses 3. Click on a license's name
Could no reproduce this bug... could you please try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Agustín Moyano from comment #13)
(In reply to Jonathan Druart from comment #11)
There is something broken.
Uncaught (in promise) Error: Missing required param "license_id"
To recreate: 1. Create a license 2. Go to /cgi-bin/koha/erm/licenses 3. Click on a license's name
Could no reproduce this bug... could you please try again?
Tried again and still the problem. yes|git bz apply 33169 yarn js:build Create a license Go to /cgi-bin/koha/erm/licenses Open the console Click on a license's name Uncaught (in promise) Error: Missing required param "license_id" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151530|0 |1 is obsolete| | --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 151797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151797&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Jonathan, please try once more. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151797|0 |1 is obsolete| | --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152068&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Not changing the status as I aint no Vue expert. But I tested things work and no warnings/errors in the console. The only thing I don't like but is not this patch responsibility, is the fact we display 'Show Thing' in the breadcrumb... I think we should be more consistent (we are not 100% consistent on this, I know but...). Right now we display Home > E-resource management > Licenses > Show license it should be: Home > E-resource management > Licenses > A licence name like we have in other places e.g Home > Tools > Patron lists > A list name I mention this in case it fits this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #18)
Not changing the status as I aint no Vue expert. But I tested things work and no warnings/errors in the console.
The only thing I don't like but is not this patch responsibility, is the fact we display 'Show Thing' in the breadcrumb... I think we should be more consistent (we are not 100% consistent on this, I know but...).
Right now we display
Home > E-resource management > Licenses > Show license
it should be:
Home > E-resource management > Licenses > A licence name
like we have in other places e.g
Home > Tools > Patron lists > A list name
I mention this in case it fits this change.
It is something I didn't manage to do with the current code (I thought there was actually a FIXME in the code but there is none). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152068|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152539&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152540&action=edit Bug 33169: Add support for FA styles Font awesome now provides a different approach to icon styles so you can specify things like: ``` <i class="fa fa-camera-retro"></i> ``` but also ``` <i class="fa-solid fa-camera-retro"></i> ``` The original implementation had a hardcoded `fa` and having an extra parameter for the *style* seemed overkill, as we would need to handle even a list of styles like on this example: ``` <i class="fa-sharp fa-solid fa-camera-retro"></i> ``` So I chose to just explicitly require the full FA icon class and pass it thru. With no manipulation on the Vue side. This patch does that, and adjusts the 'style' for some icons, as introduced by the FA v6 patchset. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152541&action=edit Bug 33169: (QA follow-up) Tidy Vue-related files Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #23 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Tomás Cohen Arazi from comment #22)
Created attachment 152541 [details] [review] Bug 33169: (QA follow-up) Tidy Vue-related files
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Thanks Tom for the follow-ups, I'll mark this as PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #24 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #19)
(In reply to Tomás Cohen Arazi from comment #18)
Not changing the status as I aint no Vue expert. But I tested things work and no warnings/errors in the console.
The only thing I don't like but is not this patch responsibility, is the fact we display 'Show Thing' in the breadcrumb... I think we should be more consistent (we are not 100% consistent on this, I know but...).
Right now we display
Home > E-resource management > Licenses > Show license
it should be:
Home > E-resource management > Licenses > A licence name
like we have in other places e.g
Home > Tools > Patron lists > A list name
I mention this in case it fits this change.
It is something I didn't manage to do with the current code (I thought there was actually a FIXME in the code but there is none).
Maybe later I can add a method to the navigation store to be able to update the last part of the breadcrumb I'll create a new bug for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Independent QA missing here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Bug 33169 depends on bug 32932, which changed state. Bug 32932 Summary: Re-structure Vue router-links to use "name" instead of urls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. Existing components/Breadcrumb.vue has not been removed. But please don't remove until the next point is not fixed. 2. I am trying to adjust the code from bug 30708 to use this, but I am struggling. I don't know if it's me or this implementation that is not flexible enough. I am trying to have, in the breadcrumbs: /preservation/trains/3 => Preservation > Trains > Show train /preservation/trains/3/items/add => Preservation > Trains > Add item to train Ideally we will need to display the name of the current resource, but that's another topic. I don't think it's feasible for now (discussed already in comment 18 and comment 19). With my try on https://gitlab.com/joubu/Koha/-/commits/preservation_module-wip-33169 I am getting: /preservation/trains/3 => Preservation > Trains > Show train (OK) /preservation/trains/3/items/add => Preservation > Trains > Show train > > Add item to train (KO there are 2 '>') Additionally "Show train" is /preservation/trains/:train_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Not sure this is related to this patch, but I am getting weird warning that seems coming from here [Vue Router warn]: Discarded invalid param(s) "license_id" when navigating. See https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#414-2... for more details. It happens, inconsistently, when going to a FormAdd view (License or Agreement) http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/erm/licenses/add When creating a new agreement the error is about agreement_id ofc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this should be backported once the above issues are resolved.. it's likely to be needed for subsequent backports around erm and other vue based modules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ping? The problems highlighted in the previous comments are blocker for future Vue developments (already in testing stage!). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
From IRC
Joubu> tcohen[m]: any news from AgustinMoyano[m] about bug 33169? huginn> ^C04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 enhancement, P5 - low, ---, agustinmoyano, Pushed to master , Improve vue breadcrumbs and left-hand menu^C tcohen[m]> I wouldn't count on him taking on that tcohen[m]> ashimema asked me, and I told him I haven't heard from him ashimema> It's bad we now how two ways of doing almost the same thing tcohen[m]> ashimema: we have two ways because the previous wasn't removed, but it is unused, right? tcohen[m]> the missing piece here would be addressing Joubu's problem reports, right? Joubu> tcohen[m]: then who? If nobody we should revert then... Joubu> we complexified the code bringing less flexibility... tcohen[m]> it didn't look complex to me, and had Matt's signature ashimema> I'm not actually sure tcohen[m]> I can revert, but we need to make sure this is not what we are aiming for ashimema> I think both are used ashimema> maybe I'm wrong tcohen[m]> the patch replaced the 'old ones' tcohen[m]> cd koha-tmpl/intranet-tmpl/prog/js/vue tcohen[m]> git grep Breadcrumb tcohen[m]> I'd like to hear from Matthew Blenkinsop. tcohen[m]> he saw some value on this on the other bug tcohen[m]> I'm not attached to it Joubu> At least I would like to know if what I want to do is possible or if we need more code Joubu> I've tried several things but didn't manage with the current code, and I don't understand the code to fix it tcohen[m]> so you tried but didn't manage to fix it tcohen[m]> ok Joubu> if nobody understand it, apart from AgustinMoyano[m] that is not going to spend more time on it, then it's hard to keep... Joubu> ofc I've tried tcohen[m]> if nobody understands it tcohen[m]> it doesn't matter if he fixes it, right? Joubu> QA step is there to make sure not only 1 person understand the code, right? :D tcohen[m]> the code in both is almost identical tcohen[m]> well no tcohen[m]> there's the 'NavigationItem' abstraction Joubu> there is almost nothing identical between the 2 approaches Joubu> in "mine" there is a build_breadcrumb function for each item Joubu> in the "new" one, there are some flag defined in the route definition (is_navigation_item, is_end_node, etc.) then the logic is in navigation.js Joubu> store/navigation.js Joubu> that is where the logic is* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I really would like to see this problem fixed, and it is preferable to fix this new implementation as it is better in the long term (less code to add and maintain in router files). However if nobody is able to provide a fix then we have a problem: we have code that we don't have under control. Or, maybe we don't even need a fix, and the current code already allows it? But how then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 153889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153889&action=edit Bug 33169: Allow breadcrumbs to accept dynamic values This patch is an example of allowing a breadcrumb to accept a dynamic value such as an agreement or license name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 153890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153890&action=edit Bug 33169: DO NOT PUSH Allow breadcrumbs to accept dynamic values This patch is an example of allowing a breadcrumb to accept a dynamic value such as an agreement or license name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Attachment #153889|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- The patch above is an example of an implementation for this by passing a parameter into the breadcrumbs from a particular component. Currently I've only set it up for Agreements and Licenses for discussion but the implementation is simple to repeat. I've also included two dummy routes to tackle Joubu's issue in comment 27 that would need removing once this example is reviewed. These have been added into Agreements as a substitute for the Preservation module Test plan 1) Apply and yarn js:build 2) Create an agreement 3) Click on the link to view the agreement 4) The breadcrumb should contain your agreement's name 5) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/ 6) Breadcrumb should read "Agreements" > "Your agreement name" > "Add item to train" 7) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/1 8) Breadcrumb should read "Agreements" > "Your agreement name" > "Add items to train" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- rel_23_05_candidate means we want backport on 23.05.x ? Patches does not apply easy because of Bug 32910 not in 23.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Isn't it just a case of skipping the 'Add support for FA styles' patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417 [Bug 34417] ERM's breadcrumb (Vue) does not display the entity's name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34418 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 [Bug 34418] Allow empty nodes in breadcrumb's elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Matt Blenkinsop from comment #35)
The patch above is an example of an implementation for this by passing a parameter into the breadcrumbs from a particular component.
Currently I've only set it up for Agreements and Licenses for discussion but the implementation is simple to repeat.
I've also included two dummy routes to tackle Joubu's issue in comment 27 that would need removing once this example is reviewed. These have been added into Agreements as a substitute for the Preservation module
Test plan 1) Apply and yarn js:build 2) Create an agreement 3) Click on the link to view the agreement 4) The breadcrumb should contain your agreement's name 5) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/ 6) Breadcrumb should read "Agreements" > "Your agreement name" > "Add item to train" 7) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/1 8) Breadcrumb should read "Agreements" > "Your agreement name" > "Add items to train"
Thanks a lot Matt, I have opened 2 bug reports, I will split your patch. See bug 34417 and 34418. See you there ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #39 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #38)
(In reply to Matt Blenkinsop from comment #35)
The patch above is an example of an implementation for this by passing a parameter into the breadcrumbs from a particular component.
Currently I've only set it up for Agreements and Licenses for discussion but the implementation is simple to repeat.
I've also included two dummy routes to tackle Joubu's issue in comment 27 that would need removing once this example is reviewed. These have been added into Agreements as a substitute for the Preservation module
Test plan 1) Apply and yarn js:build 2) Create an agreement 3) Click on the link to view the agreement 4) The breadcrumb should contain your agreement's name 5) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/ 6) Breadcrumb should read "Agreements" > "Your agreement name" > "Add item to train" 7) Navigate to /cgi-bin/koha/erm/agreements/1/items/add/1 8) Breadcrumb should read "Agreements" > "Your agreement name" > "Add items to train"
Thanks a lot Matt, I have opened 2 bug reports, I will split your patch. See bug 34417 and 34418. See you there ;)
I did not see Matt's reply before... I uploaded a patch to fix this problem in bug 34425 Could you and Matt check it out, please? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34691 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34691 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34691 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34691 [Bug 34691] Active link in the menu is not always correctly styled - again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 [Bug 34735] Current/disabled links in breadcrumbs are styled differently when in ERM module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #36)
rel_23_05_candidate means we want backport on 23.05.x ? Patches does not apply easy because of Bug 32910 not in 23.05
Any update here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157785&action=edit [23.05] Bug 33169: (QA follow-up) Fix some icons for lower FA version In the navigation some icons were missing, because they had changed names between versions, this restores them. Fixed icons concerned the navigation items: * Local * Local > Titles * EBSCO > Titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157806&action=edit [23.05 without DNP-Patch] Bug 33169: (QA follow-up) Fix some icons for lower FA version In the navigation some icons were missing, because they had changed names between versions, this restores them. Fixed icons concerned the navigation items: * Local * Local > Titles * EBSCO > Titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157806|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157807&action=edit [23.05 without DNP-Patch] Bug 33169: (QA follow-up) Fix some icons for lower FA version In the navigation some icons were missing, because they had changed names between versions, this restores them. Fixed icons concerned the navigation items: * Local * Local > Titles * EBSCO > Titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The follow-up did not apply if the DO NOT PUSH patch was not included. I made a patch that works on top of a branch without that patch too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- I think I get it. I've picked from branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 : 7202d42b2d Bug 33169: (QA follow-up) Tidy Vue-related files 6079d70e2d Bug 33169: Add support for FA styles 31f48a6d19 Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Plus the last patch attached here : 102b21d2ae Bug 33169: (QA follow-up) Fix some icons for lower FA version Looks good with Bug 33606 Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #45)
I think I get it.
I've picked from branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 :
7202d42b2d Bug 33169: (QA follow-up) Tidy Vue-related files 6079d70e2d Bug 33169: Add support for FA styles 31f48a6d19 Bug 33169: Build breadcrumbs and left-hand side menu from routes definition
Plus the last patch attached here :
102b21d2ae Bug 33169: (QA follow-up) Fix some icons for lower FA version
Looks good with Bug 33606
Pushed to 23.05.x for 23.05.05
Hi Frido, please pick the last patch from here too - it fixes 2 broken icons in the ERM navigation (3 menu items appear without an icon, if you have all features active) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #46)
(In reply to Fridolin Somers from comment #45)
I think I get it.
I've picked from branch https://gitlab.com/joubu/Koha/-/commits/bug_33606-23.05 :
7202d42b2d Bug 33169: (QA follow-up) Tidy Vue-related files 6079d70e2d Bug 33169: Add support for FA styles 31f48a6d19 Bug 33169: Build breadcrumbs and left-hand side menu from routes definition
Plus the last patch attached here :
102b21d2ae Bug 33169: (QA follow-up) Fix some icons for lower FA version
Looks good with Bug 33606
Pushed to 23.05.x for 23.05.05
Hi Frido, please pick the last patch from here too - it fixes 2 broken icons in the ERM navigation (3 menu items appear without an icon, if you have all features active)
Clearly to late for writing comment - you got them all :) Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #48 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #47)
Clearly to late for writing comment - you got them all :) Thanks!
Ouf ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 --- Comment #49 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 [Bug 35919] Add record sources CRUD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org