[Bug 26350] New: Librarians can request discharge on behalf of patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Bug ID: 26350 Summary: Librarians can request discharge on behalf of patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dpavlin@rot13.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 109511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109511&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16466 URL| |/cgi-bin/koha/members/disch | |arge.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109511|0 |1 is obsolete| | --- Comment #2 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 109516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109516&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Removed one extra empty line in second version of patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dpavlin@rot13.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109516|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109545&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109545|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109557&action=edit Bug 26350: Librarians can request discharge on behalf of patron While deploying discharges in our library we figured out that librarians need ability to request discharge document on behalf of patrons from intranet page. It was logical to add another option on Discharge patron tab. It nicely addresses Bug 16466 since it shows status of pending discharge instead of button to issue new discharge. To test: 1. apply patch 2. make sure that useDischarge is enabled in administration 3. verify that "Request new discharge" button is availabe, click on it 4. after page reload, message "Patron has pending discharge request." will appear 5. click on "Generate discharge" to approve discharge and generate pdf (this is unchanged compared to exsting workflow) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This went through so fast... I didn't even get a chance to say hi to Dobrica yet! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Dobrica, good to see you around :) Can you explain the use case please, I am not sure I understand it. If a librarian wants to let a patron download their discharge from the OPAC, the librarian can generate the discharge from the staff interface. The patron will then see a "Get your discharge" link on their account. I don't see the point of this extra step actually: a librarian request a discharge which will need to be approved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #8 from Dobrica Pavlinusic <dpavlin@rot13.org> --- That is true for the first discharge. After that, Generate discharge will always return just last discharge. If patron restriction is removed, patrons can request another discharge on opac, but librarians can't do that in current implementation. We are discharging students at the end of every year and sending discharges to the student services, so that students can enroll in next year. For us, it's essential to be able to generate discharge even if there is existing one, without the need for a student to do anything since we do have students with special needs which are unable to use opac (or web at all). After students enroll in the next year, we remove patron restriction and repeat the whole process for each year they are with us. Does this make more sense now? For us, librarians who request discharges are not the same ones who will allow it. We have local changes that also track librarian borrowernumber to be able to print name of a librarian who approved a discharge, but that will require cleanup (and implementation of permissions) before we can submit that part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 --- Comment #9 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I found additional bug when using Generate discharge without creating request through OPAC or this patch: field needed in discharges table never gets filled and is NULL. This is again problem for us, since we want to include date and time of discharge request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26350 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this has been fixed: When UseDischarge is activated, we have a "Generate discharge" button on the Discharges tab in the patron account. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org