https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 69043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69043&action=edit Bug 19596 - Don't try to get hold or items count for non-existent biblios To test: 1 - Create some orders 2 - Delete the bibs (or NULL biblionumber from DB) 3 - Try to recieve some orders 4 - Internal server error 5 - Apply patch 6 - Things should work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Reading the changes, there is this line 2 lines before: my $cnt_subscriptions = $biblio->subscriptions->count; I guess it will explode as well -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)

Reading the changes, there is this line 2 lines before: my $cnt_subscriptions = $biblio->subscriptions->count; I guess it will explode as well

Good call, I was debugging from 17.05 - the first patch without the added line will be needed there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69047|0 |1 is obsolete| | --- Comment #5 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 69242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69242&action=edit Bug 19596 - Don't try to get hold or items count for non-existent biblios Patch applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69242|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69328&action=edit Bug 19596 - Don't try to get hold or items count for non-existent biblios Patch applies and works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 19293 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #9)

(In reply to Jonathan Druart from comment #7)

...

Pushed to master for 17.11, thanks to everybody involved!

Fridolin, can we get this backported to 17.05.x please :)

fyi: it seems this patch can be skipped for 16.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.