[Bug 17374] New: Make use of fields from syspref ' DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Bug ID: 17374 Summary: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 14874 introduced syspref 'DefaultPatronSearchFields' to define what fields should be used in default patron search. It would be nice see the fields in the search fields drop down as well. At the moment the are hard coded to: Surname,Email,Borrower number,Username,Phone number,Street Address,Date of birth,Sort field 1,Sort field 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17375 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56921&action=edit Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56921|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56931&action=edit Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Nick, can you add tags <span>...</span> for the options?
From this [%- CASE 'standard' -%]Standard
to this [%- CASE 'standard' -%]<span>Standard</span> It's better to translate each string than a big one full of '%s'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56931|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 56958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56958&action=edit Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56958|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 58239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58239&action=edit Bug 17374 - Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is there a reason not to use the same list of fields on the Filters block (left side of patron list)? members/member.tt If an entry of the pref is not valid, we will know get an empty entry. It may be better to skip it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66400&action=edit Bug 17374 - QA Followup Skip invlid field names Add fields to sidebar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) If you leave the preference empty, the default will show. The default doesn't include cardnumber, I think it might be good to include it on top. 2) When using the preference, the default will still show, so there is no way to remove fields. Wouldn't it make more sense to use the non-empty pref instead of the default? For example a lot of libraries don't use the sort fields and could remove them from the list this way. The current behaviour seems especially confusing since the preference is not empty by default but includes a list of values. Deleting one of them will have no effect as long as the value is in the list of default. Failing for 2). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70226&action=edit Bug 17374 - Add cardnumber to list of searchable patron fields To test: 1 - Apply patch 2 - Perform a 'cardnumber' search for patrons 3 - Verify results as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #8)
1) If you leave the preference empty, the default will show. The default doesn't include cardnumber, I think it might be good to include it on top.
2) When using the preference, the default will still show, so there is no way to remove fields. Wouldn't it make more sense to use the non-empty pref instead of the default? For example a lot of libraries don't use the sort fields and could remove them from the list this way.
The current behaviour seems especially confusing since the preference is not empty by default but includes a list of values. Deleting one of them will have no effect as long as the value is in the list of default.
Failing for 2). 1 - Attached patch (this may be better as its own report)
2 - I think this is beyond scope here. The preference is intended to simply control the fields searched when using a 'standard' search. Adding these the dropdown is a convenience feature. I think removing fields is better done by javascript for customization. The list of fields here and the list in the pref didn't have parity before so introducing now would be a bigger change. Moving back to QA queue for second opinion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think now I understand better how this works: DefaultPatronSearchFields currently defines what is used for the "standard" search option but doesn't change the pull down. I think the description of the pref needs to be improved to be more clear about its use: Comma separated list defining the default fields to be used during a patron search Should be currently mroe something like: Comma separated list defining the default fields to be used during a spatron search using the 'standard' search option. With the new behaviour then: Comma separated list defining the default fields to be used during a spatron search using the 'standard' search option. If left empty, Koha will use: ... If you add additional fields not in the default, they will also show as separate search options in the drop down. This about right? Nick, would it make sense to you to adapt the pref description a bit? I think my problem mostly was not understanding how this is supposed to work and others might have the same problem :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 71536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71536&action=edit Bug 17374: (follow-up) update description of syspref DefaultPatronSearchFields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would have accepted a change to just .pref :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71597&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71598&action=edit Bug 17374: (QA follow-up) Skip invalid field names and add fields to sidebar Skip invlid field names Add fields to sidebar Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71599&action=edit Bug 17374: (QA follow-up) Add cardnumber to list of searchable patron fields To test: 1 - Apply patch 2 - Perform a 'cardnumber' search for patrons 3 - Verify results as expected Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71600&action=edit Bug 17374: (QA follow-up) Update description of syspref DefaultPatronSearchFields Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed koha to Koha in the last commit and changed commit subject lines to meet standard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- + [% NEXT IF display_name.length == 5 %] Hum?? How did you create the list for patronfields.inc? (if all of the borrowers table, then you are missing few). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 20263 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74828&action=edit Bug 17374: (follow-up) Remove spaces from include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #19)
+ [% NEXT IF display_name.length == 5 %]
Hum?? Ah, the indents in the file were adding 5 spaces - I didn't know where they had come from but found that solution. Improved now.
How did you create the list for patronfields.inc? (if all of the borrowers table, then you are missing few).
No, I believe I curated this to fields that were reasonable to search here. If we want more we need to add them I think ( I think some were added after this patchset ) Let me know what you want here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 2 majors problems: 1. compare columns.def and patronfields.inc => They are the "same" 2. It does not work, and cannot work without changes to C4/Utils/DataTables/Members.pm Test: Add altcontactsurname to the pref, it appears in the dropdown list, select it, search for something: everything is returned. Because of the following: my $searchfields = { # list of available fields then later: 130 for my $searchfield ( split /,/, $searchfields->{$searchfieldstype} ) { 131 push @where_strs_or, "borrowers." . $dbh->quote_identifier($searchfield) . " LIKE ?"; 132 push @where_args, $term; 133 } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71597|0 |1 is obsolete| | Attachment #71598|0 |1 is obsolete| | Attachment #71599|0 |1 is obsolete| | Attachment #71600|0 |1 is obsolete| | Attachment #74828|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93226&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #23)
2 majors problems:
1. compare columns.def and patronfields.inc => They are the "same"
Yes, but I think this is for another report. The new include removes duplicated code from two templates. I don't fully understand the use of the columns.def - it looks the same but doesn't work the same
2. It does not work, and cannot work without changes to C4/Utils/DataTables/Members.pm
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93226|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 94831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94831&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #27 from Kelly McElligott <kelly@bywatersolutions.com> --- This works as expected, see my video https://www.loom.com/share/3ab9469f887a4a2aa2793855bc99a7ad -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are debug statements left in the patch. Also, tests are missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 94876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94876&action=edit Bug 17374: (follow-up) Unit tests and remove warns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Maxime Dufresne <maxime.dufresne@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94831|0 |1 is obsolete| | --- Comment #30 from Maxime Dufresne <maxime.dufresne@inlibro.com> --- Created attachment 94890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94890&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Maxime Dufresne <maxime.dufresne@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94876|0 |1 is obsolete| | --- Comment #31 from Maxime Dufresne <maxime.dufresne@inlibro.com> --- Created attachment 94891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94891&action=edit Bug 17374: (follow-up) Unit tests and remove warns Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Maxime Dufresne <maxime.dufresne@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94890|0 |1 is obsolete| | --- Comment #32 from Maxime Dufresne <maxime.dufresne@inlibro.com> --- Created attachment 94892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94892&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Maxime Dufresne <maxime.dufresne@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.dufresne@inlibro.com --- Comment #33 from Maxime Dufresne <maxime.dufresne@inlibro.com> --- Test plan was fine, but I realized that the dropdown options were different between before and after patch: I saw at least one new field. Everything else worked as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #22)
(In reply to Jonathan Druart from comment #19)
+ [% NEXT IF display_name.length == 5 %]
Hum?? Ah, the indents in the file were adding 5 spaces - I didn't know where they had come from but found that solution. Improved now.
+ [% NEXT IF display_name.length == 5 %] Still there? Also there are debug statements in the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74828|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74828|0 |1 is obsolete| | Attachment #94891|0 |1 is obsolete| | Attachment #94892|0 |1 is obsolete| | --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96341&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96342&action=edit Bug 17374: (follow-up) Remove spaces from include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96343&action=edit Bug 17374: (follow-up) Unit tests and remove warns Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #34)
(In reply to Nick Clemens from comment #22)
(In reply to Jonathan Druart from comment #19)
+ [% NEXT IF display_name.length == 5 %]
Hum?? Ah, the indents in the file were adding 5 spaces - I didn't know where they had come from but found that solution. Improved now.
+ [% NEXT IF display_name.length == 5 %]
Still there?
Also there are debug statements in the last patch.
Looks like something happened in a rebase, patches restored and cleaned up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: [% NEXT IF display_name.length == 5 %] So this one too I guess? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96679&action=edit Bug 17374: Fix another occurrence -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14874 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98106&action=edit Bug 17374: (QA follow-up) Make search labels match with patron record Makes some small changes to the patronfields.inc to make sure the search labels match with the labels in the patron record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The tests are failing: t/db_dependent/selenium/patrons_search.t .. # Failed test 'Invalid option not added when DefaultPatronSearchFields is populated with an invalid field' # at t/db_dependent/selenium/patrons_search.t line 97. # got: '13' # expected: '12' # Failed test 'Invalid filter option not added when DefaultPatronSearchFields is populated with an invalid field' # at t/db_dependent/selenium/patrons_search.t line 98. # got: '13' # expected: '12' # Looks like you failed 2 tests of 12. t/db_dependent/selenium/patrons_search.t .. 1/1 # Failed test 'Search patrons' # at t/db_dependent/selenium/patrons_search.t line 137. # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98478&action=edit Bug 17374: (follow-up) Remove all spaces from include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96341|0 |1 is obsolete| | Attachment #96342|0 |1 is obsolete| | Attachment #96343|0 |1 is obsolete| | Attachment #96679|0 |1 is obsolete| | Attachment #98106|0 |1 is obsolete| | Attachment #98478|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100436&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> Bug 17374: (follow-up) Remove all spaces from include file Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100437&action=edit Bug 17374: (follow-up) Remove spaces from include file Bug 17374: Fix another occurrence Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100438&action=edit Bug 17374: (follow-up) Unit tests Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100439&action=edit Bug 17374: (QA follow-up) Make search labels match with patron record Makes some small changes to the patronfields.inc to make sure the search labels match with the labels in the patron record. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I cleaned the patches a bit (squash and remove warn, whitespaces, etc.). After this patch, columns.def and koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc list the borrowers fields. And bug 22844 is going to introduce a third one (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json). We will need to centralize all of them in a single file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #50 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch preserves the release notes| |current dropdown choices | |for patron search, but adds | |fields additionally defined | |in the | |DefaultPatronSearchFields | |system preference to the | |list of available options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 [Bug 26916] Allow patron attributes in DefaultPatronSearchFields syspref and patron search dropdown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org