[Bug 28367] New: Wrong plack condition in C4/Auth_with_shibboleth.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Bug ID: 28367 Summary: Wrong plack condition in C4/Auth_with_shibboleth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org C4/Auth_with_shibboleth.pm has: if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) When others have: if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) This has been highlighted by https://gitlab.com/koha-community/koha-testing-docker/-/issues/249 that introduces a PLACK_WORKERS env vars, and t/Auth_with_shibboleth.t was failing with # Failed test 'checkpw_shib tests' # at t/Auth_with_shibboleth.t line 335. Invalid parameter passed, categorycode= does not exist# Looks like your test exited with 255 just after 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121094&action=edit Bug 28367: Fix plack condition in C4/Auth_with_shibboleth.pm C4/Auth_with_shibboleth.pm has: if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) When others have: if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) This has been highlighted by https://gitlab.com/koha-community/koha-testing-docker/-/issues/249 that introduces a PLACK_WORKERS env vars, and t/Auth_with_shibboleth.t was failing with # Failed test 'checkpw_shib tests' # at t/Auth_with_shibboleth.t line 335. Invalid parameter passed, categorycode= does not exist# Looks like your test exited with 255 just after 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121099&action=edit Bug 28367: (follow-up) Fix plack condition in C4/Auth_with_shibboleth.pm There were 2 occurrences! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- We should create a method C4::Context->is_plack() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12 |21.05.00,20.11.06,20.05.12, released in| |19.11.18 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Got a request for this so: Backported: Pushed to 19.11.x branch for 19.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Actually it was for v19.11.18-2, a micro release to contain this last moment patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12, released in|19.11.18 |19.11.18-2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28367 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12, released in|19.11.18-2 |19.11.19 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- And I mixed up the patches. It will be for v19.11.19 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org