[Bug 5004] New: Do not block deletion of cities when instances exist in borrowers table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Summary: Do not block deletion of cities when instances exist in borrowers table Change sponsored?: --- Product: Koha Version: HEAD Platform: All URL: /cgi-bin/koha/admin/cities.pl?op=delete_confirm OS/Version: All Status: NEW Severity: normal Priority: P5 Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 When you try to delete a city Koha does a check for entries in the borrowers table which match that city: select count(*) as total from borrowers,cities where borrowers.city=cities.city_name and cityid=? But why shouldn't it be possible to delete a city whether or not there are entries in borrowers? Nothing is preventing me from continuing to add patrons with that city manually, typing in the city details myself. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|paul.poulain@biblibre.com |oleonard@myacpl.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-08-16 19:30:32 UTC --- Created attachment 2527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2527 Proposed fix for HEAD -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> 2010-11-15 13:10:28 UTC --- Signed off on patch. I note that admin/roadtype.pl has the same issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2010-11-15 15:16:43 UTC --- Created attachment 2757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2757 Proposed fix for roadtype.pl Accompanying (but not dependent) patch for roadtype.pl The road types interface didn't block deletion of road types in use, but the script included the same queries that cities.pl did, as if it intended to. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-18 20:53:57 UTC --- Pushed, please test and close -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-30 13:49:36 UTC --- This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-09 15:10:20 UTC --- This bug is mentioned in: Fix for Bug 5004, Don't block deletion of cities when instances exist in borrowers table http://lists.koha-community.org/pipermail/koha-patches/2010-November/013013.... Another bug 5004 fix, this time for road types http://lists.koha-community.org/pipermail/koha-patches/2010-November/013016.... Another bug 5004 fix, this time for road types http://lists.koha-community.org/pipermail/koha-patches/2010-November/013028.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5004 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org