[Bug 23078] New: Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Bug ID: 23078 Summary: Use Koha.Preference in OPAC global header include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: katrin.fischer@bsz-bw.de, testopia@bugs.koha-community.org Target Milestone: --- To prevent bugs like Bug 23076 the OPAC's doc-head-close.inc include file should use 'Koha.Preference' syntax everywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90460&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 90460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90460 Bug 23078: Use Koha.Preference in OPAC global header include Review of attachment 90460: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23078&attachment=90460) ----------------------------------------------------------------- Fix the lines that should be removed, and I'll sign off. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc @@ +9,4 @@
[% IF ( bidi ) %] [% Asset.css("lib/bootstrap/css/bootstrap-rtl.min.css") | $raw %] + [% Asset.css("lib/jquery/jquery-ui-rtl.css") | $raw %] + [% Asset.css("css/right-to-left.css") | $raw %]
Nice clean up moves. @@ +20,1 @@
[% END %]
You probably could have deleted these three lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Because extra lines got left behind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #3)
Because extra lines got left behind.
18 [% IF ( bidi ) %] 19 [% ELSE %] 20 [% END %] Those ones. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90460|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90481&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 frederik.chenier@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90481|0 |1 is obsolete| | --- Comment #6 from frederik.chenier@inlibro.com --- Created attachment 90936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90936&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. Signed-off-by: frederik <frederik@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Frederik seems to have forgotten to set the status to signed off. My former comments were addressed. Fixing status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Nadine Pierre <nadine.pierre@InLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90936|0 |1 is obsolete| | --- Comment #8 from Nadine Pierre <nadine.pierre@InLibro.com> --- Created attachment 91349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91349&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, can you explain why those 2 lines in Auth.pm are still needed with patches applied? OpacAdditionalStylesheet => C4::Context->preference("OpacAdditionalStylesheet"), opaclayoutstylesheet => C4::Context->preference("opaclayoutstylesheet"), Also found these: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:<link rel="shortcut icon" href="[% IF ( OpacFavicon ) %][% OpacFavicon | url %][% ELSE %][% interface | html %]/[% theme | html %]/images/favicon.ico[% END %]" type="image/x-icon" /> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/printslip.tt:<link rel="shortcut icon" href="[% IF ( OpacFavicon ) %][% OpacFavicon | url %][% ELSE %][% interface | html %]/[% theme | html %]/images/favicon.ico[% END %]" type="image/x-icon" /> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:[% IF ( Koha.Preference('OpacFavicon') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt:[% IF ( OPACUserCSS ) %]<style>[% OPACUserCSS | $raw %]</style>[% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt:[% IF ( Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') | $raw %]</style>[% END %] Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91430&action=edit Bug 23078: (follow-up) Update self checkout help page This patch takes care of some preference instances I missed in the self checkout module's help page. It also removes some obsolete lines from Auth.pm. To test, apply the patch and re-test based on the previous test plan. Also test in the self-checkout module by logging into self checkout and clicking the "Help" link in the upper right of the screen. The settings of the following preferences should be shown correctly: - OpacFavicon - OPACUserCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91431&action=edit Bug 23078: (follow-up) Update self checkout help page This patch takes care of some preference instances I missed in the self checkout module's help page. It also removes some obsolete lines from Auth.pm. To test, apply the patch and re-test based on the previous test plan. Also test in the self-checkout module by logging into self checkout and clicking the "Help" link in the upper right of the screen. The settings of the following preferences should be shown correctly: - OpacFavicon - OPACUserCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91431|0 |1 is obsolete| | --- Comment #12 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91503&action=edit Bug 23078: (follow-up) Update self checkout help page This patch takes care of some preference instances I missed in the self checkout module's help page. It also removes some obsolete lines from Auth.pm. To test, apply the patch and re-test based on the previous test plan. Also test in the self-checkout module by logging into self checkout and clicking the "Help" link in the upper right of the screen. The settings of the following preferences should be shown correctly: - OpacFavicon - OPACUserCSS Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91626&action=edit Bug 20607: Make Koha::SearchEngine::Elasticsearch::reset_elasticsearch_mappings take weight into account Test plan: - apply this patch, - edit admin/searchengine/elasticsearch/mappings.yaml to add weight for some fields, - go to admin > search engine configuration, - reset your mappings (add ?op=reset&i_know_what_i_am_doing=1 to url), - check that weights you've added are set Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91627&action=edit Bug 20607: (QA follow-up) Test corrections Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #91626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91627|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|nick@bywatersolutions.com |katrin.fischer@bsz-bw.de Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think Nick accidentally marked this one PQA when meaning to mark another bug, setting back to SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91349|0 |1 is obsolete| | Attachment #91503|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91654&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91655&action=edit Bug 23078: (follow-up) Update self checkout help page This patch takes care of some preference instances I missed in the self checkout module's help page. It also removes some obsolete lines from Auth.pm. To test, apply the patch and re-test based on the previous test plan. Also test in the self-checkout module by logging into self checkout and clicking the "Help" link in the upper right of the screen. The settings of the following preferences should be shown correctly: - OpacFavicon - OPACUserCSS Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 --- Comment #20 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- It is nice to see code becoming more clean and clear. Thanks a lot for this job ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org