[Bug 39698] New: Add option to expand responsive datatable rows by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Bug ID: 39698 Summary: Add option to expand responsive datatable rows by default Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org kohaTables on the OPAC are currently configured to display a '+' button, when the table is overflowing. When this '+' is clicked, the overflowing cells are displayed on new lines. I propose a system preference that would control whether this button is a '+' or a '-' by default, and thusly, whether the overflowing cells are shown or hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 181288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181288&action=edit Bug 39698: Add option to expand responsive datatable This patch adds the 'OPACTableColExpandedByDefault' system preference, disabled by default, which controls whether responsive datatable rows are expanded or not. This work has been performed after recommendations from a recent accessibility audit. TO TEST: a) set 'OpacLocationBranchToDisplay' to both b) search the OPAC for history, select first result c) zoom your browser in to maxiumum, scroll down to holdings table - notice how the rows are collapsed by default, with '+' visible **apply patch** e) refresh details page, notice how the behaviour is currently unchanged f) change new 'OPACTableColExpandedByDefault' syspref to 'Expand' g) return to OPAC details page, refresh, zoom in - notice how the rows are now expanded by default, with '-' visible **sign off** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181288|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 181560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181560&action=edit Bug 39698: Add option to expand responsive datatable This patch adds the 'OPACTableColExpandedByDefault' system preference, disabled by default, which controls whether responsive datatable rows are expanded or not. This work has been performed after recommendations from a recent accessibility audit. TO TEST: a) set 'OpacLocationBranchToDisplay' to both b) search the OPAC for history, select first result c) zoom your browser in to maxiumum, scroll down to holdings table - notice how the rows are collapsed by default, with '+' visible **apply patch** e) refresh details page, notice how the behaviour is currently unchanged f) change new 'OPACTableColExpandedByDefault' syspref to 'Expand' g) return to OPAC details page, refresh, zoom in - notice how the rows are now expanded by default, with '-' visible **sign off** Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181561&action=edit Screenshots - Not expanded and expanded I've signed off, as it does what is says in the test plan. However, the "buttons" with the + and - don't really look that great to me, and I find them confusing. Particularly the lack of contrast with the darker and lighter green, I don't see any + sign to expand, and the - is very hard to see. See the attached screenshots - hopefully what I'm describing makes sense! Testing notes (using KTD): 1. After applying the patch, run a database update: updatedatabase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #3)
Created attachment 181561 [details] Screenshots - Not expanded and expanded
I've signed off, as it does what is says in the test plan.
However, the "buttons" with the + and - don't really look that great to me, and I find them confusing.
This is a bug caused by 39600 which adds inclusion of datatables.min.css to the OPAC's doc-head-close.inc in a way that overrides opac.css. I have filed Bug 39761. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39761 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #4)
This is a bug caused by 39600 which adds inclusion of datatables.min.css to the OPAC's doc-head-close.inc in a way that overrides opac.css. I have filed Bug 39761.
Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Your atomicupdate is named 'bug_xxxxx_' and doesn't have the proper permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181560|0 |1 is obsolete| | --- Comment #7 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 183250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183250&action=edit Bug 39698: Add option to expand responsive datatable This patch adds the 'OPACTableColExpandedByDefault' system preference, disabled by default, which controls whether responsive datatable rows are expanded or not. This work has been performed after recommendations from a recent accessibility audit. TO TEST: a) set 'OpacLocationBranchToDisplay' to both b) search the OPAC for history, select first result c) zoom your browser in to maxiumum, scroll down to holdings table - notice how the rows are collapsed by default, with '+' visible **apply patch** e) refresh details page, notice how the behaviour is currently unchanged f) change new 'OPACTableColExpandedByDefault' syspref to 'Expand' g) return to OPAC details page, refresh, zoom in - notice how the rows are now expanded by default, with '-' visible **sign off** Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Jake Deery <jake.deery@openfifth.co.uk> --- Thanks, Lucas. Got around to setting the mode on that file, and have renamed it to match expectations. Ta, Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement lets you release notes| |control the default | |responsiveness of OPAC | |tables, such as OPAC search | |history. New system | |preference | |'OPACTableColExpandedByDefa | |ult' controls the default | |behavor. Tables are | |collapsed by default with a | |'+' to expand, and when | |expanded a '-' is visible | |to collapse. (This | |enhancement is a result of | |recommendations from a | |recent accessibility | |audit.) | | | |** Sponsored by: Open Fifth | |** Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183250|0 |1 is obsolete| | --- Comment #9 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 183826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183826&action=edit Bug 39698: Add option to expand responsive datatable This patch adds the 'OPACTableColExpandedByDefault' system preference, disabled by default, which controls whether responsive datatable rows are expanded or not. This work has been performed after recommendations from a recent accessibility audit. TO TEST: a) set 'OpacLocationBranchToDisplay' to both b) search the OPAC for history, select first result c) zoom your browser in to maxiumum, scroll down to holdings table - notice how the rows are collapsed by default, with '+' visible **apply patch** e) refresh details page, notice how the behaviour is currently unchanged f) change new 'OPACTableColExpandedByDefault' syspref to 'Expand' g) return to OPAC details page, refresh, zoom in - notice how the rows are now expanded by default, with '-' visible **sign off** Sponsored-by: British Museum Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191052&action=edit Bug 39698: Add option to expand responsive datatable This patch adds the 'OPACTableColExpandedByDefault' system preference, disabled by default, which controls whether responsive datatable rows are expanded or not. This work has been performed after recommendations from a recent accessibility audit. TO TEST: a) set 'OpacLocationBranchToDisplay' to both b) search the OPAC for history, select first result c) zoom your browser in to maxiumum, scroll down to holdings table - notice how the rows are collapsed by default, with '+' visible **apply patch** e) refresh details page, notice how the behaviour is currently unchanged f) change new 'OPACTableColExpandedByDefault' syspref to 'Expand' g) return to OPAC details page, refresh, zoom in - notice how the rows are now expanded by default, with '-' visible **sign off** Sponsored-by: British Museum Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In your DB update: bug_number => "xxxxx", -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Failed QA |Passed QA Comma delimited| |British Museum list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191052|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193338&action=edit Bug 39698: Add option to expand responsive datatable This patch adds the 'OPACTableColExpandedByDefault' system preference, disabled by default, which controls whether responsive datatable rows are expanded or not. This work has been performed after recommendations from a recent accessibility audit. TO TEST: a) set 'OpacLocationBranchToDisplay' to both b) search the OPAC for history, select first result c) zoom your browser in to maxiumum, scroll down to holdings table - notice how the rows are collapsed by default, with '+' visible **apply patch** e) refresh details page, notice how the behaviour is currently unchanged f) change new 'OPACTableColExpandedByDefault' syspref to 'Expand' g) return to OPAC details page, refresh, zoom in - notice how the rows are now expanded by default, with '-' visible **sign off** Sponsored-by: British Museum Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- A couple of comments: 1. TT tags within script tags are going to be prohibited very soon (bug 41324), please make sure to not introduce new occurrences. 2. Why is this not an option at the table level, in the table settings? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39698 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #15 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org