[Bug 35856] New: Runtime parameter modal should provide option of ":all"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Bug ID: 35856 Summary: Runtime parameter modal should provide option of ":all" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: lucas@bywatersolutions.com, nick@bywatersolutions.com Depends on: 35746 The modal interface to insert a runtime parameters should offer the option to make one's parameter offer the "All" option. Currently, use of the All feature requires one to manually add ":all" at the end of the parameter and is not clearly suggested by anything in the interface. The modal could include a checkbox one could check to add ":all" to the constructed parameter. It would probably be helpful to display some text reminding the user that one must use LIKE rather than = with ":all." I've made this depend on bug 35746, which adds an ":in" option. If that gets pushed, it'd be great to have it included as an option in the modal, too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 [Bug 35746] Multiple selections for parameters used in the IN function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 161357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161357&action=edit Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Should this be 'Signed-off'? I don't see am attached patch/sign-off line. Setting this back to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161357|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162306&action=edit Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Very exciting! In documentation, we should mention that :in requires IN and :all requires LIKE. Otherwise, the reports don't work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162306|0 |1 is obsolete| | --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 162307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162307&action=edit Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Caroline! I just made a small update to the patch that adds a default check box for choosing a single parameter plus some tool tips to explain the need for using =, LIKE and IN in the query expression. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162307|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162308&action=edit Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Brendan! I was mentioning it for the documentation team when we'll add it to the manual, but this is good too! :) Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162308|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164050&action=edit Bug 35856: added options to runtime parameter modal This patch adds radio checkboxes to the reports runtime parameter modal for adding param options :all and :in. The :in param option functionality depends on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 Test plan: 1. Apply patch 2. Create a report from SQL 3. Click Insert runtime parameter and choose any option other than date, list or text field 4. Note the form now includes a radio checkbox for parameter options 5. Choose 'Include option for all' and click Insert parameter 6. Note the parameter is inserted with :all option like <<label|authval:all>> 7. Choose 'Allow multiple selections' and click Insert parameter 8. Note the parameter is inserted with :in option like <<label|authval:in>> 9. Make sure that parameter options are not included on the form for date, list and text field Thanks! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164287&action=edit Bug 35856: (follow-up) Expand display of radio button choices This patch swaps out the icons with tooltips with visible hints, expanding the radio button options to hopefully make it more readable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Owen! I like the vertical layout of the radio buttons. It's much easier to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Status|Passed QA |BLOCKED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on a patch currently in Failed QA - please bring these back to my queue soon! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |additional_work_needed, | |release-notes-needed --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I struggle a tiny bit with the phrasing "Query expression". Hm, but what to write instead? A suggestion: Query condition must use ... operator. What do you think? (setting additional_work_needed to highlight the question) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |philip.orr@lmscloud.de Text to go in the| |This patch adds radio release notes| |checkboxes to the runtime | |parameter modal menu used | |in creating SQL reports to | |allow the runtime parameter | |to use multiple values | |("... in the following list | |of values") or to allow | |choosing all values ("... | |in all the values"). | |Now | |when you use the modal menu | |for inserting a runtime | |parameter while creating an | |SQL report you can simply | |click on the radio button | |for "single parameter | |only", "include option for | |all" or "allow multiple | |selections" after choosing | |the runtime parameter you | |want to add. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Anyone have an opinion here for Katrins comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #13)
I struggle a tiny bit with the phrasing "Query expression". Hm, but what to write instead? A suggestion: Query condition must use ... operator. What do you think?
(setting additional_work_needed to highlight the question)
Dropping this. We can deal with it later, if someone wants to change it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35856 Bug 35856 depends on bug 35746, which changed state. Bug 35746 Summary: Multiple selections for parameters used in the IN function https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org