https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 [Bug 20181] Allow plugins to add CSS and Javascript to OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20496 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Kyle M Hall from comment #1)

Point of note, we check two different things: 1) Is UseKohaPlugins enabled 2) Is enabled_plugins set in the Koha config file

I think we should have a method in Koha::Plugins that checks both and returns true/false. If there are any parts of Koha that only check one for a good reason, we can have another method to check just that.

Or you could return a hashref. Configured => true/false # true when both syspref and config Failures => [systempreference,config,other] # an array with what fails Then: my $rv = Koha::Plugins->configured(); if ( $rv->{Configured} ) { ... } or perhaps if ( $rv->{Configured} || ! grep { $_ eq 'systempreference' } @{$rv->Failures} ) { ... } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.