[Bug 18505] New: OPAC Search History page does not respect OpacPublic syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Bug ID: 18505 Summary: OPAC Search History page does not respect OpacPublic syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The opac-search-history script is missing the standard `authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),` line and therefore does not repsect the OpacPublic preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 62809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62809&action=edit BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62809|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 62919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62919&action=edit [SIGNED OFF]] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62919|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 62923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62923&action=edit [SIGNED OFF] BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed my sign-off line. Martin, do you want to fix authorship too? From: PTFS Admin <hosting@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oh, good catch on the Authorship line.. I must have done the original work on a different server to normal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 62925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62925&action=edit BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62925|BUG 18505: |[SIGNED OFF] BUG 18505: description|opac-search-history does |opac-search-history does |not respect opacPublic |not respect opacPublic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only noticed because of my own mistake (typo in my git alias) :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62925|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62945&action=edit BUG 18505: opac-search-history does not respect opacPublic The opac-search-history page was available regardless of the opacPublic setting, this patch corrects that. Test plan, set opacPublic to 'No', test whether opac-search-history page is available when not logged in, note that it is. Apply patch, test whether opac-search-history is still available when not logged in, note that you should be redirected to the login page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18505 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org