[Bug 17891] New: typo in housebound.tt div tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Bug ID: 17891 Summary: typo in housebound.tt div tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In housebound.tt there is a end tag div missing closing character '>'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 58868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58868&action=edit Bug 17891 - typo in housebound.tt div tag In housebound.tt there is a end tag div missing closing character '>'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- BTW there is maybe a problem with this page, circ-menu.inc should be inside <div id="bd">. Maybe the corrected tag should be deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58868|0 |1 is obsolete| | --- Comment #3 from Zoe Schoeler <crazy.mental.onion@gmail.com> --- Created attachment 59036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59036&action=edit Bug 17891 - typo in housebound.tt div tag In housebound.tt there is a end tag div missing closing character '>'. Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That does not work, the menu on the left is now misplaced at the bottom. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #5 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59101&action=edit Bug 17891: Followup This fixes the menu layout issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59036|0 |1 is obsolete| | Attachment #59101|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 59184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59184&action=edit [SIGNED OFF] Bug 17891 - typo in housebound.tt div tag In housebound.tt there is a end tag div missing closing character '>'. Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 59185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59185&action=edit [SIGNED OFF] Bug 17891: Followup This fixes the menu layout issue. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59184|0 |1 is obsolete| | Attachment #59185|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59231&action=edit Bug 17891: Remove extra div tag Followup This fixes the menu layout issue. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |crazy.mental.onion@gmail.co |y.org |m --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I removed the first patch as it was wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers@biblibre.co |crazy.mental.onion@gmail.co |m |m QA Contact|crazy.mental.onion@gmail.co |jonathan.druart@bugs.koha-c |m |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59231|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59237&action=edit Bug 17891: Remove extra div tag in the housebound module This fixes the menu layout issue. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.02. Fixed author's name - Emma Smith <emma.nakamura.smith@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 [Bug 5670] Housebound Readers Module -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org