[Bug 39415] New: Add subfield g to Geogrpahic name authority fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Bug ID: 39415 Summary: Add subfield g to Geogrpahic name authority fields Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Subfield g is a valid subfield - we should respect it if present: https://www.loc.gov/marc/authority/adx51.html https://www.loc.gov/marc/authority/ad151.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 179629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179629&action=edit Bug 39415: Add subfield g for geographic name authorities This patch adds the subfield g to the hardcoded list of controlled fields so that it is no longer ignored To test: 1 - Edit a GEOGR_NAME authority to add a g subfield to field 151 2 - Search for this authority in Authorities 3 - Don't see g 4 - Apply patch, restart all 5 - Search again, you see g! 6 - Edit a record and link to the authority 7 - g is copied over! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Is the way that at step 6 the only way an authority will be linked is by looking it up from the cataloging editor, and that automatic linking from either AutoLinkBiblios or the Link authorities automatically button will not work, the intended behavior? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #2)
Is the way that at step 6 the only way an authority will be linked is by looking it up from the cataloging editor, and that automatic linking from either AutoLinkBiblios or the Link authorities automatically button will not work, the intended behavior?
No, it should work on all the methods, this was just a simple explanation for the test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179629|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 180191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180191&action=edit Bug 39415: Add subfield g for geographic name authorities This patch adds the subfield g to the hardcoded list of controlled fields so that it is no longer ignored To test: 1 - Edit a GEOGR_NAME authority to add a g subfield to field 151 2 - Search for this authority in Authorities 3 - Don't see g 4 - Apply patch, restart all 5 - Search again, you see g! 6 - Edit a record and link to the authority 7 - g is copied over! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |domm@plix.at |y.org | CC| |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180191|0 |1 is obsolete| | --- Comment #5 from Thomas Klausner <domm@plix.at> --- Created attachment 180350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180350&action=edit Bug 39415: Add subfield g for geographic name authorities This patch adds the subfield g to the hardcoded list of controlled fields so that it is no longer ignored To test: 1 - Edit a GEOGR_NAME authority to add a g subfield to field 151 2 - Search for this authority in Authorities 3 - Don't see g 4 - Apply patch, restart all 5 - Search again, you see g! 6 - Edit a record and link to the authority 7 - g is copied over! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 --- Comment #6 from Thomas Klausner <domm@plix.at> --- works! and nice, we recently had some problems with 151g not properly showing up, thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Test plan which fails: 1. Set the prefs AutoLinkBiblios and CatalogModuleRelink to Do 2. Create three GEOGR_NAME authorities, 151$aDismal Swamp and 151$aDismal Swamp$gSouth and 151$aPit of Despair 3. In a new bib record, type Pit of Despair in 651 a and either Save and continue editing or Link authorities automatically. In either case, you should see the bib heading linked to the authority, which tells you linking is working 4. In a duplicate 651 field, type Dismal Swamp in a, and in another duplicate 651 field type Dismal Swamp in a and South in g 5. Again, Save and continue editing or Link authorities automatically You would expect to have Dismal Swamp linked to the Dismal Swamp authority, and Dismal Swamp -- South linked to that authority, but instead you have both linked to the same Dismal Swamp authority. The patch adds g to $bib_heading_fields in '151' which doesn't actually exist as a bib field, and not to '651' which does. I'd just add a follow-up patch to add it to 651, which makes my test plan succeed, but I'm not sure whether the 1xx things in $bib_heading_fields which do not exist are still required for something and have to be kept in sync with the 6xx ones, or if they should just be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add subfield g to |Add subfield g to |Geogrpahic name authority |Geographic name authority |fields |fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180740&action=edit Bug 39415: (follow-up) Add 651g to bib heading fields as well Test plan: 0 - Apply other patches - reindex your catalog perl misc/search_tools/rebuild_elasticsearch.pl -v -d 1 - Set the prefs AutoLinkBiblios and CatalogModuleRelink to Do 2 - Create three GEOGR_NAME authorities: 151$aDismal Swamp 151$aDismal Swamp$gSouth 151$aPit of Despair 3 - In a new bib record, add 651 fields 651$aPit of Despair 651$aDismal Swamp 651$aDismal Swamp$gSouth 4 - Click Link authorities automatically 5 - 'Pit of despair' links correct - other records both link to 'Dismal swamp' 6 - Apply this patch, restart_all 7 - Click Link authorities automatically 8 - Dismal Swamp and Dismal Swamp South are correctly linked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180350|0 |1 is obsolete| | --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 180803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180803&action=edit Bug 39415: Add subfield g for geographic name authorities This patch adds the subfield g to the hardcoded list of controlled fields so that it is no longer ignored To test: 1 - Edit a GEOGR_NAME authority to add a g subfield to field 151 2 - Search for this authority in Authorities 3 - Don't see g 4 - Apply patch, restart all 5 - Search again, you see g! 6 - Edit a record and link to the authority 7 - g is copied over! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180740|0 |1 is obsolete| | --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 180804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180804&action=edit Bug 39415: (follow-up) Add 651g to bib heading fields as well Test plan: 0 - Apply other patches - reindex your catalog perl misc/search_tools/rebuild_elasticsearch.pl -v -d 1 - Set the prefs AutoLinkBiblios and CatalogModuleRelink to Do 2 - Create three GEOGR_NAME authorities: 151$aDismal Swamp 151$aDismal Swamp$gSouth 151$aPit of Despair 3 - In a new bib record, add 651 fields 651$aPit of Despair 651$aDismal Swamp 651$aDismal Swamp$gSouth 4 - Click Link authorities automatically 5 - 'Pit of despair' links correct - other records both link to 'Dismal swamp' 6 - Apply this patch, restart_all 7 - Click Link authorities automatically 8 - Dismal Swamp and Dismal Swamp South are correctly linked Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|domm@plix.at |matt.blenkinsop@openfifth.c | |o.uk CC| |matt.blenkinsop@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180803|0 |1 is obsolete| | --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181847&action=edit Bug 39415: Add subfield g for geographic name authorities This patch adds the subfield g to the hardcoded list of controlled fields so that it is no longer ignored To test: 1 - Edit a GEOGR_NAME authority to add a g subfield to field 151 2 - Search for this authority in Authorities 3 - Don't see g 4 - Apply patch, restart all 5 - Search again, you see g! 6 - Edit a record and link to the authority 7 - g is copied over! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180804|0 |1 is obsolete| | --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181848&action=edit Bug 39415: (follow-up) Add 651g to bib heading fields as well Test plan: 0 - Apply other patches - reindex your catalog perl misc/search_tools/rebuild_elasticsearch.pl -v -d 1 - Set the prefs AutoLinkBiblios and CatalogModuleRelink to Do 2 - Create three GEOGR_NAME authorities: 151$aDismal Swamp 151$aDismal Swamp$gSouth 151$aPit of Despair 3 - In a new bib record, add 651 fields 651$aPit of Despair 651$aDismal Swamp 651$aDismal Swamp$gSouth 4 - Click Link authorities automatically 5 - 'Pit of despair' links correct - other records both link to 'Dismal swamp' 6 - Apply this patch, restart_all 7 - Click Link authorities automatically 8 - Dismal Swamp and Dismal Swamp South are correctly linked Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39415 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org